resource/gitlab_group: Fix passing false to API for explicitly set optional attributes

Closes: #1154

Author: timofurrer

internal/provider/resource_gitlab_group.go

@@ -183,7 +183,9 @@ func resourceGitlabGroupCreate(ctx context.Context, d *schema.ResourceData, meta
 		options.ShareWithGroupLock = gitlab.Bool(v.(bool))
 	}
 
-	if v, ok := d.GetOk("require_two_factor_authentication"); ok {
+	// nolint:staticcheck // SA1019 ignore deprecated GetOkExists
+	// lintignore: XR001 // TODO: replace with alternative for GetOkExists
+	if v, ok := d.GetOkExists("require_two_factor_authentication"); ok {
 		options.RequireTwoFactorAuth = gitlab.Bool(v.(bool))
 	}
 
@@ -195,19 +197,25 @@ func resourceGitlabGroupCreate(ctx context.Context, d *schema.ResourceData, meta
 		options.ProjectCreationLevel = stringToProjectCreationLevel(v.(string))
 	}
 
-	if v, ok := d.GetOk("auto_devops_enabled"); ok {
+	// nolint:staticcheck // SA1019 ignore deprecated GetOkExists
+	// lintignore: XR001 // TODO: replace with alternative for GetOkExists
+	if v, ok := d.GetOkExists("auto_devops_enabled"); ok {
 		options.AutoDevopsEnabled = gitlab.Bool(v.(bool))
 	}
 
 	if v, ok := d.GetOk("subgroup_creation_level"); ok {
 		options.SubGroupCreationLevel = stringToSubGroupCreationLevel(v.(string))
 	}
 
-	if v, ok := d.GetOk("emails_disabled"); ok {
+	// nolint:staticcheck // SA1019 ignore deprecated GetOkExists
+	// lintignore: XR001 // TODO: replace with alternative for GetOkExists
+	if v, ok := d.GetOkExists("emails_disabled"); ok {
 		options.EmailsDisabled = gitlab.Bool(v.(bool))
 	}
 
-	if v, ok := d.GetOk("mentions_disabled"); ok {
+	// nolint:staticcheck // SA1019 ignore deprecated GetOkExists
+	// lintignore: XR001 // TODO: replace with alternative for GetOkExists
+	if v, ok := d.GetOkExists("mentions_disabled"); ok {
 		options.MentionsDisabled = gitlab.Bool(v.(bool))
 	}
 
@@ -232,7 +240,9 @@ func resourceGitlabGroupCreate(ctx context.Context, d *schema.ResourceData, meta
 
 	var updateOptions gitlab.UpdateGroupOptions
 
-	if v, ok := d.GetOk("prevent_forking_outside_group"); ok {
+	// nolint:staticcheck // SA1019 ignore deprecated GetOkExists
+	// lintignore: XR001 // TODO: replace with alternative for GetOkExists
+	if v, ok := d.GetOkExists("prevent_forking_outside_group"); ok {
 		updateOptions.PreventForkingOutsideGroup = gitlab.Bool(v.(bool))
 	}
 

internal/provider/resource_gitlab_group_test.go

@@ -313,6 +313,36 @@ func testAccCheckGitlabGroupDisappears(group *gitlab.Group) resource.TestCheckFu
 	}
 }
 
+func TestAccGitlabGroup_SetDefaultFalseBooleansOnCreate(t *testing.T) {
+	rInt := acctest.RandInt()
+
+	resource.ParallelTest(t, resource.TestCase{
+		ProviderFactories: providerFactories,
+		CheckDestroy:      testAccCheckGitlabProjectDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(`
+					resource "gitlab_group" "this" {
+						name             = "foo-%d"
+						path             = "path-%d"
+						visibility_level = "public"
+
+						require_two_factor_authentication = false
+						auto_devops_enabled               = false
+						emails_disabled                   = false
+						mentions_disabled                 = false
+						prevent_forking_outside_group     = false
+					}`, rInt, rInt),
+			},
+			{
+				ResourceName:      "gitlab_group.this",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
 func testAccCheckGitlabGroupExists(n string, group *gitlab.Group) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[n]