Merge pull request #811 from gitlabhq/fix-group-variable-test

Fix group variable test

Author: armsnyder

gitlab/provider_test.go

@@ -2,6 +2,7 @@ package gitlab
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"testing"
 
@@ -17,7 +18,7 @@ func init() {
 	if os.Getenv(resource.TestEnvVar) != "" {
 		testAccProvider = Provider()
 		if err := testAccProvider.Configure(context.TODO(), &terraform.ResourceConfig{}); err != nil {
-			panic(err) // lintignore: R009 // TODO: Resolve this tfproviderlint issue
+			panic(fmt.Sprintf("%#v", err)) // lintignore: R009 // TODO: Resolve this tfproviderlint issue
 		}
 		testAccProviders = map[string]*schema.Provider{
 			"gitlab": testAccProvider,

gitlab/resource_gitlab_group_variable_test.go

@@ -148,7 +148,7 @@ func testAccCheckGitlabGroupVariableExists(n string, groupVariable *gitlab.Group
 		}
 		conn := testAccProvider.Meta().(*gitlab.Client)
 
-		gotVariable, _, err := conn.GroupVariables.GetVariable(repoName, key)
+		gotVariable, _, err := conn.GroupVariables.GetVariable(repoName, key, modifyRequestAddEnvironmentFilter(rs.Primary.Attributes["environment_scope"]))
 		if err != nil {
 			return err
 		}