Merge branch 'ashmckenzie/improve-binary-building' into 'main'

Use go build so we can use -o

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/1117

Merged-by: Igor Drozdov <[email protected]>
Approved-by: Jaime Martinez <[email protected]>
Approved-by: Igor Drozdov <[email protected]>
Co-authored-by: Ash McKenzie <[email protected]>

Author: 2 people

Makefile

@@ -101,11 +101,12 @@ _script_install:
 	bin/install
 
 compile: bin/gitlab-shell bin/gitlab-sshd
+
 bin/gitlab-shell: $(GO_SOURCES)
-	GOBIN="$(CURDIR)/bin" go install $(GOBUILD_FLAGS) ./cmd/...
+	go build $(GOBUILD_FLAGS) -o $(CURDIR)/bin ./cmd/...
 
 bin/gitlab-sshd: $(GO_SOURCES)
-	GOBIN="$(CURDIR)/bin" go install $(GOBUILD_FLAGS) ./cmd/gitlab-sshd
+	go build $(GOBUILD_FLAGS) -o $(CURDIR)/bin/gitlab-sshd ./cmd/gitlab-sshd
 
 check:
 	bin/check