Apply 2 suggestion(s) to 1 file(s)

Archish27 · ashmckenzie · Archish27 · commit defe4d4be6dc · 2024-09-11T06:26:59.000Z
Co-authored-by: Ash McKenzie &lt;amckenzie@gitlab.com&gt;
diff --git a/internal/command/discover/discover.go b/internal/command/discover/discover.go
@@ -12,6 +12,8 @@ import (
 	"gitlab.com/gitlab-org/gitlab-shell/v14/internal/gitlabnet/discover"
 )
 
+type logDataKey struct{}
+
 // Command struct encapsulates the necessary components for executing the Discover command.
 type Command struct {
 	Config     *config.Config
@@ -35,7 +37,7 @@ func (c *Command) Execute(ctx context.Context) (context.Context, error) {
 		_, _ = fmt.Fprintf(c.ReadWriter.Out, "Welcome to GitLab, @%s!\n", response.Username)
 	}
 
-	ctxWithLogData := context.WithValue(ctx, "logData", logData)
+	ctxWithLogData := context.WithValue(ctx, logDataKey{}, logData)
 
 	return ctxWithLogData, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@ import (`
`12`	`12`	`"gitlab.com/gitlab-org/gitlab-shell/v14/internal/gitlabnet/discover"`
`13`	`13`	`)`
`14`	`14`
	`15`	`+type logDataKey struct{}`
	`16`	`+`
`15`	`17`	`// Command struct encapsulates the necessary components for executing the Discover command.`
`16`	`18`	`type Command struct {`
`17`	`19`	`Config *config.Config`
`@@ -35,7 +37,7 @@ func (c *Command) Execute(ctx context.Context) (context.Context, error) {`
`35`	`37`	`_, _ = fmt.Fprintf(c.ReadWriter.Out, "Welcome to GitLab, @%s!\n", response.Username)`
`36`	`38`	`}`
`37`	`39`
`38`		`- ctxWithLogData := context.WithValue(ctx, "logData", logData)`
	`40`	`+ ctxWithLogData := context.WithValue(ctx, logDataKey{}, logData)`
`39`	`41`
`40`	`42`	`return ctxWithLogData, nil`
`41`	`43`	`}`