You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cmd/gitlab-shell/command/command.go:74: cmd/gitlab-shell/command/command.go:74: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: When 1.21+ only Golang is support..." (godox)
34
+
cmd/gitlab-shell/command/command.go:74:3: cmd/gitlab-shell/command/command.go:74: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: When 1.21+ only Golang is support..." (godox)
35
35
cmd/gitlab-shell/main.go:1:1: package-comments: should have a package comment (revive)
36
36
cmd/gitlab-shell/main.go:42:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
37
37
cmd/gitlab-shell/main.go:48:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
38
38
cmd/gitlab-shell/main.go:53:23: Error return value of `logCloser.Close` is not checked (errcheck)
39
39
cmd/gitlab-shell/main.go:60:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
40
40
cmd/gitlab-shell/main.go:61:3: exitAfterDefer: os.Exit will exit, and `defer logCloser.Close()` will not run (gocritic)
41
-
internal/command/authorizedkeys/authorized_keys.go:29: internal/command/authorizedkeys/authorized_keys.go:29: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "TODO: Log this event once we have a cons..." (godox)
41
+
cmd/gitlab-sshd/acceptance_test.go:458:2: encoded-compare: use require.JSONEq (testifylint)
42
+
internal/command/authorizedkeys/authorized_keys.go:29:4: internal/command/authorizedkeys/authorized_keys.go:29: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "TODO: Log this event once we have a cons..." (godox)
42
43
internal/command/command.go:1:1: package-comments: should have a package comment (revive)
43
44
internal/command/command.go:15:6: exported: exported type Command should have comment or be unexported (revive)
44
45
internal/command/command.go:19:6: exported: exported type LogMetadata should have comment or be unexported (revive)
internal/command/lfstransfer/gitlab_backend.go:229:1: exported: exported method GitlabBackend.Download should have comment or be unexported (revive)
58
59
internal/command/lfstransfer/gitlab_backend.go:237:1: exported: exported method GitlabBackend.LockBackend should have comment or be unexported (revive)
59
60
internal/command/lfstransfer/lfstransfer.go:26:6: exported: exported type Command should have comment or be unexported (revive)
60
-
internal/command/lfstransfer/lfstransfer.go:32: Function 'Execute' is too long (63 > 60) (funlen)
61
-
internal/command/lfstransfer/lfstransfer.go:52:20: context-keys-type: should not use basic type string as key in context.WithValue (revive)
61
+
internal/command/lfstransfer/lfstransfer.go:32:1: exported: exported method Command.Execute should have comment or be unexported (revive)
62
+
internal/command/lfstransfer/lfstransfer.go:52:20: context-keys-type: should not use basic type untyped string as key in context.WithValue (revive)
internal/command/lfstransfer/lfstransfer_test.go:19:2: import 'github.com/git-lfs/pktline' is not allowed from list 'test' (depguard)
64
65
internal/command/lfstransfer/lfstransfer_test.go:278:2: declaration has 3 blank identifiers (dogsled)
@@ -80,7 +81,7 @@ internal/config/config.go:79:2: var-naming: struct field GitlabUrl should be Git
80
81
internal/config/config.go:131:1: exported: exported method YamlDuration.UnmarshalYAML should have comment or be unexported (revive)
81
82
internal/config/config.go:142:1: exported: exported method Config.ApplyGlobalState should have comment or be unexported (revive)
82
83
internal/config/config.go:144:12: Error return value of `os.Setenv` is not checked (errcheck)
83
-
internal/config/config.go:196:9: copylocks: assignment copies lock value to *cfg: gitlab.com/gitlab-org/gitlab-shell/v14/internal/config.Config contains sync.Once contains sync/atomic.Uint32 contains sync/atomic.noCopy (govet)
84
+
internal/config/config.go:196:9: copylocks: assignment copies lock value to *cfg: gitlab.com/gitlab-org/gitlab-shell/v14/internal/config.Config contains sync.Once contains sync.noCopy (govet)
84
85
internal/config/config.go:199:22: G304: Potential file inclusion via variable (gosec)
85
86
internal/config/config.go:210:3: var-naming: var unescapedUrl should be unescapedURL (revive)
86
87
internal/config/config.go:256:1: receiver-naming: receiver name cfg should be consistent with previous receiver name c for Config (revive)
@@ -90,6 +91,6 @@ internal/gitlabnet/client.go:21:15: ST1005: error strings should not be capitali
90
91
internal/gitlabnet/client.go:27:1: exported: exported function ParseJSON should have comment or be unexported (revive)
91
92
internal/gitlabnet/client.go:35:1: exported: exported function ParseIP should have comment or be unexported (revive)
92
93
internal/gitlabnet/healthcheck/client_test.go:19:41: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
93
-
internal/gitlabnet/lfstransfer/client.go:137: internal/gitlabnet/lfstransfer/client.go:137: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: This causes tests to fail" (godox)
94
+
internal/gitlabnet/lfstransfer/client.go:137:3: internal/gitlabnet/lfstransfer/client.go:137: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: This causes tests to fail" (godox)
94
95
internal/sshd/server_config_test.go:5:2: SA1019: "crypto/dsa" has been deprecated since Go 1.16 because it shouldn't be used: DSA is a legacy algorithm, and modern alternatives such as Ed25519 (implemented by package crypto/ed25519) should be used instead. Keys with 1024-bit moduli (L1024N160 parameters) are cryptographically weak, while bigger keys are not widely supported. Note that FIPS 186-5 no longer approves DSA for signature generation. (staticcheck)
95
96
internal/sshd/sshd.go:268:6: func `extractDataFromContext` is unused (unused)
0 commit comments