Skip to content

Commit bbb1387

Browse files
committed
Update last known acceptable after go bump
1 parent e3a0b20 commit bbb1387

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

support/lint_last_known_acceptable.txt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,15 @@ client/testserver/testserver.go:52:17: Error return value of `server.Serve` is n
3131
client/testserver/testserver.go:117:18: G304: Potential file inclusion via variable (gosec)
3232
cmd/gitlab-shell-authorized-keys-check/main.go:40:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
3333
cmd/gitlab-shell-authorized-keys-check/main.go:43:13: unnecessary conversion (unconvert)
34-
cmd/gitlab-shell/command/command.go:74: cmd/gitlab-shell/command/command.go:74: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: When 1.21+ only Golang is support..." (godox)
34+
cmd/gitlab-shell/command/command.go:74:3: cmd/gitlab-shell/command/command.go:74: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: When 1.21+ only Golang is support..." (godox)
3535
cmd/gitlab-shell/main.go:1:1: package-comments: should have a package comment (revive)
3636
cmd/gitlab-shell/main.go:42:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
3737
cmd/gitlab-shell/main.go:48:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
3838
cmd/gitlab-shell/main.go:53:23: Error return value of `logCloser.Close` is not checked (errcheck)
3939
cmd/gitlab-shell/main.go:60:14: Error return value of `fmt.Fprintf` is not checked (errcheck)
4040
cmd/gitlab-shell/main.go:61:3: exitAfterDefer: os.Exit will exit, and `defer logCloser.Close()` will not run (gocritic)
41-
internal/command/authorizedkeys/authorized_keys.go:29: internal/command/authorizedkeys/authorized_keys.go:29: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "TODO: Log this event once we have a cons..." (godox)
41+
cmd/gitlab-sshd/acceptance_test.go:458:2: encoded-compare: use require.JSONEq (testifylint)
42+
internal/command/authorizedkeys/authorized_keys.go:29:4: internal/command/authorizedkeys/authorized_keys.go:29: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "TODO: Log this event once we have a cons..." (godox)
4243
internal/command/command.go:1:1: package-comments: should have a package comment (revive)
4344
internal/command/command.go:15:6: exported: exported type Command should have comment or be unexported (revive)
4445
internal/command/command.go:19:6: exported: exported type LogMetadata should have comment or be unexported (revive)
@@ -57,8 +58,8 @@ internal/command/lfstransfer/gitlab_backend.go:224:1: exported: exported method
5758
internal/command/lfstransfer/gitlab_backend.go:229:1: exported: exported method GitlabBackend.Download should have comment or be unexported (revive)
5859
internal/command/lfstransfer/gitlab_backend.go:237:1: exported: exported method GitlabBackend.LockBackend should have comment or be unexported (revive)
5960
internal/command/lfstransfer/lfstransfer.go:26:6: exported: exported type Command should have comment or be unexported (revive)
60-
internal/command/lfstransfer/lfstransfer.go:32: Function 'Execute' is too long (63 > 60) (funlen)
61-
internal/command/lfstransfer/lfstransfer.go:52:20: context-keys-type: should not use basic type string as key in context.WithValue (revive)
61+
internal/command/lfstransfer/lfstransfer.go:32:1: exported: exported method Command.Execute should have comment or be unexported (revive)
62+
internal/command/lfstransfer/lfstransfer.go:52:20: context-keys-type: should not use basic type untyped string as key in context.WithValue (revive)
6263
internal/command/lfstransfer/lfstransfer.go:114:9: composites: gitlab.com/gitlab-org/gitlab-shell/v14/internal/command/shared/accessverifier.Command struct literal uses unkeyed fields (govet)
6364
internal/command/lfstransfer/lfstransfer_test.go:19:2: import 'github.com/git-lfs/pktline' is not allowed from list 'test' (depguard)
6465
internal/command/lfstransfer/lfstransfer_test.go:278:2: declaration has 3 blank identifiers (dogsled)
@@ -80,7 +81,7 @@ internal/config/config.go:79:2: var-naming: struct field GitlabUrl should be Git
8081
internal/config/config.go:131:1: exported: exported method YamlDuration.UnmarshalYAML should have comment or be unexported (revive)
8182
internal/config/config.go:142:1: exported: exported method Config.ApplyGlobalState should have comment or be unexported (revive)
8283
internal/config/config.go:144:12: Error return value of `os.Setenv` is not checked (errcheck)
83-
internal/config/config.go:196:9: copylocks: assignment copies lock value to *cfg: gitlab.com/gitlab-org/gitlab-shell/v14/internal/config.Config contains sync.Once contains sync/atomic.Uint32 contains sync/atomic.noCopy (govet)
84+
internal/config/config.go:196:9: copylocks: assignment copies lock value to *cfg: gitlab.com/gitlab-org/gitlab-shell/v14/internal/config.Config contains sync.Once contains sync.noCopy (govet)
8485
internal/config/config.go:199:22: G304: Potential file inclusion via variable (gosec)
8586
internal/config/config.go:210:3: var-naming: var unescapedUrl should be unescapedURL (revive)
8687
internal/config/config.go:256:1: receiver-naming: receiver name cfg should be consistent with previous receiver name c for Config (revive)
@@ -90,6 +91,6 @@ internal/gitlabnet/client.go:21:15: ST1005: error strings should not be capitali
9091
internal/gitlabnet/client.go:27:1: exported: exported function ParseJSON should have comment or be unexported (revive)
9192
internal/gitlabnet/client.go:35:1: exported: exported function ParseIP should have comment or be unexported (revive)
9293
internal/gitlabnet/healthcheck/client_test.go:19:41: unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
93-
internal/gitlabnet/lfstransfer/client.go:137: internal/gitlabnet/lfstransfer/client.go:137: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: This causes tests to fail" (godox)
94+
internal/gitlabnet/lfstransfer/client.go:137:3: internal/gitlabnet/lfstransfer/client.go:137: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: This causes tests to fail" (godox)
9495
internal/sshd/server_config_test.go:5:2: SA1019: "crypto/dsa" has been deprecated since Go 1.16 because it shouldn't be used: DSA is a legacy algorithm, and modern alternatives such as Ed25519 (implemented by package crypto/ed25519) should be used instead. Keys with 1024-bit moduli (L1024N160 parameters) are cryptographically weak, while bigger keys are not widely supported. Note that FIPS 186-5 no longer approves DSA for signature generation. (staticcheck)
9596
internal/sshd/sshd.go:268:6: func `extractDataFromContext` is unused (unused)

0 commit comments

Comments
 (0)