Merge branch '779-add-support-for-go-1-23-for-ci-jobs' into 'main'

Resolve "Add support for Go 1.23"

Closes #779

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/1128

Merged-by: Igor Drozdov <[email protected]>
Approved-by: Igor Drozdov <[email protected]>
Reviewed-by: Igor Drozdov <[email protected]>
Reviewed-by: Ash McKenzie <[email protected]>
Co-authored-by: Ash McKenzie <[email protected]>

Author: 2 people

.gitlab-ci.yml

@@ -25,7 +25,7 @@ variables:
   CI_DEBUG_SERVICES: 'true'
   RUST_VERSION: "rust-1.73"
   UBI_VERSION: "8.6"
-  IMAGE_TAG: "rubygems-3.4-git-2.36-exiftool-12.60"
+  IMAGE_TAG: "rubygems-3.4-git-2.45-exiftool-12.60"
   GITLAB_ADVANCED_SAST_ENABLED: 'true'
 
 workflow:
@@ -94,7 +94,7 @@ default:
 .go-matrix-job:
   parallel:
     matrix:
-      - GO_VERSION: ["golang-1.21", "golang-1.22"]
+      - GO_VERSION: ["golang-1.22", "golang-1.23"]
 
 ################################################################################
 # Prepare jobs

cmd/gitlab-shell/command/command.go

@@ -71,7 +71,7 @@ func NewWithUsername(gitlabUsername string, env sshenv.Env, config *config.Confi
 		return nil, err
 	}
 
-	// When 1.21+ only Golang is supported, it can be refactored by using slices.Contains
+	// FIXME: When 1.21+ only Golang is supported, it can be refactored by using slices.Contains
 	if env.NamespacePath != "" {
 		exists := false
 		for _, gitCmd := range commandargs.GitCommands {

go.mod

@@ -1,8 +1,8 @@
 module gitlab.com/gitlab-org/gitlab-shell/v14
 
-go 1.21
+go 1.22
 
-toolchain go1.21.9
+toolchain go1.22.6
 
 require (
 	github.com/charmbracelet/git-lfs-transfer v0.1.1-0.20240809134258-2cab0ea18f7e