Comment Client public methods and drop oid

Author: ashmckenzie

internal/gitlabnet/lfstransfer/client.go

@@ -168,7 +168,8 @@ func (c *Client) Batch(operation string, reqObjects []*BatchObject, ref string,
 	return response, nil
 }
 
-func (c *Client) GetObject(oid, href string, headers map[string]string) (io.ReadCloser, int64, error) {
+// GetObject performs an HTTP GET request for the object
+func (c *Client) GetObject(_, href string, headers map[string]string) (io.ReadCloser, int64, error) {
 	req, _ := newHTTPRequest(http.MethodGet, href, nil)
 	for key, value := range headers {
 		req.Header.Add(key, value)
@@ -188,7 +189,8 @@ func (c *Client) GetObject(oid, href string, headers map[string]string) (io.Read
 	return res.Body, res.ContentLength, nil
 }
 
-func (c *Client) PutObject(oid, href string, headers map[string]string, r io.Reader) error {
+// PutObject performs an HTTP PUT request for the object
+func (c *Client) PutObject(_, href string, headers map[string]string, r io.Reader) error {
 	req, _ := newHTTPRequest(http.MethodPut, href, r)
 	for key, value := range headers {
 		req.Header.Add(key, value)

support/lint_last_known_acceptable.txt

@@ -396,11 +396,9 @@ internal/gitlabnet/lfstransfer/client.go:104:5: exported: exported var ClientHea
 internal/gitlabnet/lfstransfer/client.go:106:1: exported: exported function NewClient should have comment or be unexported (revive)
 internal/gitlabnet/lfstransfer/client.go:124:1: exported: exported method Client.Batch should have comment or be unexported (revive)
 internal/gitlabnet/lfstransfer/client.go:125: internal/gitlabnet/lfstransfer/client.go:125: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "FIXME: This causes tests to fail" (godox)
-internal/gitlabnet/lfstransfer/client.go:171:28: unused-parameter: parameter 'oid' seems to be unused, consider removing or renaming it as _ (revive)
-internal/gitlabnet/lfstransfer/client.go:191:28: unused-parameter: parameter 'oid' seems to be unused, consider removing or renaming it as _ (revive)
-internal/gitlabnet/lfstransfer/client.go:212:1: exported: exported method Client.Lock should have comment or be unexported (revive)
-internal/gitlabnet/lfstransfer/client.go:269:1: exported: exported method Client.Unlock should have comment or be unexported (revive)
-internal/gitlabnet/lfstransfer/client.go:319:1: exported: exported method Client.ListLocksVerify should have comment or be unexported (revive)
+internal/gitlabnet/lfstransfer/client.go:214:1: exported: exported method Client.Lock should have comment or be unexported (revive)
+internal/gitlabnet/lfstransfer/client.go:271:1: exported: exported method Client.Unlock should have comment or be unexported (revive)
+internal/gitlabnet/lfstransfer/client.go:321:1: exported: exported method Client.ListLocksVerify should have comment or be unexported (revive)
 internal/gitlabnet/personalaccesstoken/client_test.go:30:5: go-require: do not use require in http handlers (testifylint)
 internal/gitlabnet/twofactorrecover/client_test.go:30:5: go-require: do not use require in http handlers (testifylint)
 internal/gitlabnet/twofactorverify/client_test.go:24:3: go-require: do not use require in http handlers (testifylint)