Migrate to mockery's packages configuration

This drops the `go:generate` lines and adds mocks for all files. This
makes generating mocks a lot faster and avoids the need to annotate
interfaces.

Previously `make generated_files` took 75 seconds on my machine; now
it only takes 4 seconds despite the increased amount of generated
code.

See https://vektra.github.io/mockery/latest/migrating_to_packages/ for
more details.

Author: stanhu

.mockery.yaml

@@ -0,0 +1,13 @@
+with-expecter: True
+inpackage: True
+dir: "{{.InterfaceDir}}"
+mockname: "{{.Mock}}{{.InterfaceName | camelcase}}"
+outpkg: "{{.PackageName}}"
+filename: "mock_{{.InterfaceName}}.go"
+all: True
+packages:
+ gitlab.com/gitlab-org/gitlab-runner:
+    config:
+      recursive: True
+      exclude:
+        - executors/internal/autoscaler

Makefile

@@ -48,7 +48,7 @@ export PATH := $(localBin):$(PATH)
 # Development Tools
 GOCOVER_COBERTURA = gocover-cobertura
 
-MOCKERY_VERSION ?= 2.43.0
+MOCKERY_VERSION ?= 2.53.3
 MOCKERY = mockery
 
 PROTOC := $(localBin)/protoc
@@ -194,6 +194,7 @@ generated_files: $(GENERATED_FILES_TOOLS)
 	find . -type f -name '*.pb.go' -delete
 	go generate -v -x ./...
 	cd ./helpers/runner_wrapper/api && go generate -v -x ./...
+	mockery
 
 check_generated_files: generated_files
 	# Checking the differences

cache/adapter.go

@@ -22,7 +22,6 @@ type GoCloudURL struct {
 	Environment map[string]string
 }
 
-//go:generate mockery --name=Adapter --inpackage
 type Adapter interface {
 	GetDownloadURL(context.Context) PresignedURL
 	GetUploadURL(context.Context) PresignedURL

cache/azure/credentials_resolver.go

@@ -7,7 +7,6 @@ import (
 	"gitlab.com/gitlab-org/gitlab-runner/common"
 )
 
-//go:generate mockery --name=credentialsResolver --inpackage
 type credentialsResolver interface {
 	Resolve() error
 	Signer() (sasSigner, error)