Moves AI feedback URI state handling to provider

Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4480)

Author: sergeibbb

src/commands/aiFeedback.ts

@@ -6,11 +6,7 @@ import type { AIResultContext } from '../plus/ai/aiProviderService';
 import { extractAIResultContext } from '../plus/ai/utils/-webview/ai.utils';
 import type { QuickPickItemOfT } from '../quickpicks/items/common';
 import { command } from '../system/-webview/command';
-import { setContext } from '../system/-webview/context';
-import { UriMap } from '../system/-webview/uriMap';
-import type { Deferrable } from '../system/function/debounce';
-import { debounce } from '../system/function/debounce';
-import { filterMap, map } from '../system/iterable';
+import { map } from '../system/iterable';
 import { Logger } from '../system/logger';
 import { ActiveEditorCommand } from './commandBase';
 import { getCommandUri } from './commandBase.utils';
@@ -45,32 +41,20 @@ export class AIFeedbackUnhelpfulCommand extends ActiveEditorCommand {
 
 type UnhelpfulResult = { reasons?: AIFeedbackUnhelpfulReasons[]; custom?: string };
 
-const uriResponses = new UriMap<AIFeedbackEvent['sentiment']>();
-let _updateContextDebounced: Deferrable<() => void> | undefined;
-
 async function sendFeedback(container: Container, uri: Uri, sentiment: AIFeedbackEvent['sentiment']): Promise<void> {
 	const context = extractAIResultContext(container, uri);
 	if (!context) return;
 
 	try {
-		const previous = uriResponses.get(uri);
+		const previous = container.aiFeedback.getFeedbackResponse(uri);
 		if (sentiment === previous) return;
 
 		let unhelpful: UnhelpfulResult | undefined;
 		if (sentiment === 'unhelpful') {
 			unhelpful = await showUnhelpfulFeedbackPicker();
 		}
 
-		uriResponses.set(uri, sentiment);
-		_updateContextDebounced ??= debounce(() => {
-			void setContext('gitlens:tabs:ai:helpful', [
-				...filterMap(uriResponses, ([uri, sentiment]) => (sentiment === 'helpful' ? uri : undefined)),
-			]);
-			void setContext('gitlens:tabs:ai:unhelpful', [
-				...filterMap(uriResponses, ([uri, sentiment]) => (sentiment === 'unhelpful' ? uri : undefined)),
-			]);
-		}, 100);
-		_updateContextDebounced();
+		container.aiFeedback.setFeedbackResponse(uri, sentiment);
 
 		sendFeedbackEvent(container, { source: 'ai:markdown-preview' }, context, sentiment, unhelpful);
 	} catch (ex) {

src/plus/ai/utils/-webview/ai.utils.ts

@@ -298,7 +298,7 @@ export function extractAIResultContext(container: Container, uri: Uri | undefine
 	// Check for untitled documents with stored changelog feedback context
 	if (uri?.scheme === 'untitled') {
 		try {
-			return container.aiFeedback.getChangelogFeedback(uri.toString());
+			return container.aiFeedback.getChangelogDocument(uri.toString());
 		} catch {
 			return undefined;
 		}

src/telemetry/aiFeedbackProvider.ts

@@ -1,9 +1,12 @@
 import type { Disposable, Uri } from 'vscode';
 import { workspace } from 'vscode';
+import type { AIFeedbackEvent } from '../constants.telemetry';
 import type { AIResultContext } from '../plus/ai/aiProviderService';
 import { setContext } from '../system/-webview/context';
+import { UriMap } from '../system/-webview/uriMap';
 import type { Deferrable } from '../system/function/debounce';
 import { debounce } from '../system/function/debounce';
+import { filterMap } from '../system/iterable';
 
 export class AIFeedbackProvider implements Disposable {
 	constructor() {
@@ -14,20 +17,22 @@ export class AIFeedbackProvider implements Disposable {
 	}
 
 	public addChangelogDocument(uri: Uri, context: AIResultContext): void {
-		this.setChangelogFeedback(uri.toString(), context);
+		this.setChangelogDocument(uri.toString(), context);
 		this.addChangelogUri(uri);
 	}
 
 	private removeChangelogDocument(uri: Uri): void {
-		this.deleteChangelogFeedback(uri.toString());
+		this.deleteChangelogDocument(uri.toString());
 		this.removeChangelogUri(uri);
 	}
 
 	private readonly _disposables: Disposable[] = [];
 	dispose(): void {
 		this._disposables.forEach(d => void d.dispose());
-		this._changelogFeedbacks.clear();
+		this._uriResponses.clear();
+		this._changelogDocuments.clear();
 		this._changelogUris.clear();
+		this._updateFeedbackContextDebounced = undefined;
 		this._updateChangelogContextDebounced = undefined;
 	}
 
@@ -54,14 +59,39 @@ export class AIFeedbackProvider implements Disposable {
 	}
 
 	// Storage for AI feedback context associated with changelog documents
-	private readonly _changelogFeedbacks = new Map<string, AIResultContext>();
-	getChangelogFeedback(documentUri: string): AIResultContext | undefined {
-		return this._changelogFeedbacks.get(documentUri);
+	private readonly _changelogDocuments = new Map<string, AIResultContext>();
+	getChangelogDocument(documentUri: string): AIResultContext | undefined {
+		return this._changelogDocuments.get(documentUri);
 	}
-	private setChangelogFeedback(documentUri: string, context: AIResultContext): void {
-		this._changelogFeedbacks.set(documentUri, context);
+	private setChangelogDocument(documentUri: string, context: AIResultContext): void {
+		this._changelogDocuments.set(documentUri, context);
 	}
-	private deleteChangelogFeedback(documentUri: string): void {
-		this._changelogFeedbacks.delete(documentUri);
+	private deleteChangelogDocument(documentUri: string): void {
+		this._changelogDocuments.delete(documentUri);
+	}
+
+	// Storage for AI feedback responses by URI
+	private readonly _uriResponses = new UriMap<AIFeedbackEvent['sentiment']>();
+	private _updateFeedbackContextDebounced: Deferrable<() => void> | undefined;
+	private updateFeedbackContext(): void {
+		this._updateFeedbackContextDebounced ??= debounce(() => {
+			void setContext('gitlens:tabs:ai:helpful', [
+				...filterMap(this._uriResponses, ([uri, sentiment]) => (sentiment === 'helpful' ? uri : undefined)),
+			]);
+			void setContext('gitlens:tabs:ai:unhelpful', [
+				...filterMap(this._uriResponses, ([uri, sentiment]) => (sentiment === 'unhelpful' ? uri : undefined)),
+			]);
+		}, 100);
+		this._updateFeedbackContextDebounced();
+	}
+	setFeedbackResponse(uri: Uri, sentiment: AIFeedbackEvent['sentiment']): void {
+		const previous = this._uriResponses.get(uri);
+		if (sentiment === previous) return;
+
+		this._uriResponses.set(uri, sentiment);
+		this.updateFeedbackContext();
+	}
+	getFeedbackResponse(uri: Uri): AIFeedbackEvent['sentiment'] | undefined {
+		return this._uriResponses.get(uri);
 	}
 }