Allow settings to be false - boolean

Emmanouil Konstantinidis · Emmanouil Konstantinidis · commit 78f769cac0ab · 2015-08-01T13:26:43.000+01:00
diff --git a/src/js/stores/settings.js b/src/js/stores/settings.js
@@ -22,16 +22,19 @@ var SettingsStore = Reflux.createStore({
       settings = JSON.parse(settings);
     }
 
-    if (!settings.participating) {
+    if (typeof settings.participating !== 'boolean') {
       settings.participating = false;
     }
-    if (!settings.playSound) {
+
+    if (typeof settings.playSound !== 'boolean') {
       settings.playSound = true;
     }
-    if (!settings.showNotifications) {
+
+    if (typeof settings.showNotifications !== 'boolean') {
       settings.showNotifications = true;
     }
-    if (!settings.openAtStartup) {
+
+    if (typeof settings.openAtStartup !== 'boolean') {
       settings.openAtStartup = false;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -22,16 +22,19 @@ var SettingsStore = Reflux.createStore({`
`22`	`22`	`settings = JSON.parse(settings);`
`23`	`23`	`}`
`24`	`24`
`25`		`- if (!settings.participating) {`
	`25`	`+ if (typeof settings.participating !== 'boolean') {`
`26`	`26`	`settings.participating = false;`
`27`	`27`	`}`
`28`		`- if (!settings.playSound) {`
	`28`	`+`
	`29`	`+ if (typeof settings.playSound !== 'boolean') {`
`29`	`30`	`settings.playSound = true;`
`30`	`31`	`}`
`31`		`- if (!settings.showNotifications) {`
	`32`	`+`
	`33`	`+ if (typeof settings.showNotifications !== 'boolean') {`
`32`	`34`	`settings.showNotifications = true;`
`33`	`35`	`}`
`34`		`- if (!settings.openAtStartup) {`
	`36`	`+`
	`37`	`+ if (typeof settings.openAtStartup !== 'boolean') {`
`35`	`38`	`settings.openAtStartup = false;`
`36`	`39`	`}`
`37`	`40`