Skip to content

Commit 625cb27

Browse files
authored
fix: page layouts (#1766)
* fix: page layouts Signed-off-by: Adam Setch <[email protected]> * fix: page layouts Signed-off-by: Adam Setch <[email protected]> --------- Signed-off-by: Adam Setch <[email protected]>
1 parent cd83ed9 commit 625cb27

15 files changed

+43
-34
lines changed

src/renderer/App.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export const App = () => {
4747
<BaseStyles>
4848
<AppProvider>
4949
<Router>
50-
<div className="flex h-full overflow-x-hidden overflow-y-auto flex-col pl-10 bg-gitify-background">
50+
<div className="flex h-screen overflow-x-hidden overflow-y-auto flex-col pl-10 bg-gitify-background">
5151
<Loading />
5252
<Sidebar />
5353
<Routes>

src/renderer/components/Oops.test.tsx

+5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
import { render } from '@testing-library/react';
2+
import { ensureStableEmojis } from '../__mocks__/utils';
23
import { Oops } from './Oops';
34

45
describe('renderer/components/Oops.tsx', () => {
6+
beforeEach(() => {
7+
ensureStableEmojis();
8+
});
9+
510
it('should render itself & its children - specified error', () => {
611
const mockError = {
712
title: 'Error title',

src/renderer/components/__snapshots__/AllRead.test.tsx.snap

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/components/__snapshots__/Oops.test.tsx.snap

+8-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/components/layout/Centered.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export const Centered: FC<ICentered> = ({
1616
align="center"
1717
justify="center"
1818
padding="spacious"
19-
className={fullHeight && 'min-h-screen'}
19+
className={fullHeight && 'h-full'}
2020
>
2121
{props.children}
2222
</Stack>

src/renderer/components/layout/Page.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ interface IPage {
77

88
export const Page: FC<IPage> = (props: IPage) => {
99
return (
10-
<div className="flex flex-col h-screen" data-testid={props.id}>
10+
<div className="flex flex-col h-full" data-testid={props.id}>
1111
{props.children}
1212
</div>
1313
);

src/renderer/components/layout/__snapshots__/Centered.test.tsx.snap

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/components/layout/__snapshots__/EmojiSplash.test.tsx.snap

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/components/layout/__snapshots__/Page.test.tsx.snap

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/routes/LoginWithOAuthApp.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export const LoginWithOAuthAppRoute: FC = () => {
6767

6868
return (
6969
<Page id="Login With OAuth App">
70-
<form onSubmit={handleSubmit}>
70+
<form onSubmit={handleSubmit} className="-mt-5">
7171
<FieldInput
7272
name="hostname"
7373
label="Hostname"

src/renderer/routes/__snapshots__/Filters.test.tsx.snap

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/routes/__snapshots__/Login.test.tsx.snap

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/routes/__snapshots__/LoginWithOAuthApp.test.tsx.snap

+8-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/routes/__snapshots__/LoginWithPersonalAccessToken.test.tsx.snap

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/renderer/routes/__snapshots__/Settings.test.tsx.snap

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)