Skip to content

Commit 5128d80

Browse files
authored
Merge pull request #419 from codebytere/update-to-electron-9
chore: upgrade to Electron v9
2 parents d0ca1a0 + 2e9d2c1 commit 5128d80

File tree

5 files changed

+1315
-1086
lines changed

5 files changed

+1315
-1086
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112
"electron-updater": "^4.2.5",
113113
"final-form": "^4.19.1",
114114
"lodash": "^4.17.15",
115-
"menubar": "^8.0.1",
115+
"menubar": "^9.0.1",
116116
"nprogress": "=0.2.0",
117117
"react": "=16.13.1",
118118
"react-dom": "=16.13.1",
@@ -141,7 +141,7 @@
141141
"@types/react-redux": "^7.1.7",
142142
"@types/react-transition-group": "^4.2.4",
143143
"@types/styled-components": "^5.0.1",
144-
"electron": "^8.2.0",
144+
"electron": "^9.0.0",
145145
"electron-builder": "^22.4.1",
146146
"electron-notarize": "^0.3.0",
147147
"jest": "^25.2.7",

src/js/components/ui/checkbox.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ const StyledCheckbox = styled.div`
4545
}
4646
4747
${Icon} {
48-
// @ts-ignore
49-
visibility: ${(props) => (props.isChecked ? 'visible' : 'hidden')};
48+
visibility: ${(props) => ((props as any).isChecked ? 'visible' : 'hidden')};
5049
}
5150
`;
5251

src/js/routes/__snapshots__/settings.test.tsx.snap

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
1212
>
1313
Settings
1414
</h3>
15-
<button
15+
<a
1616
aria-label="Close Settings"
1717
className="sc-fzoLsD cUlvxj"
1818
onClick={[Function]}
1919
>
2020
×
21-
</button>
21+
</a>
2222
</div>
2323
<div
2424
className="sc-Axmtr fLAtpJ"
@@ -39,7 +39,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
3939
type="checkbox"
4040
/>
4141
<div
42-
className="sc-AxhUy VqymF"
42+
className="sc-AxhUy juIZhB"
4343
>
4444
<svg
4545
className="sc-AxiKw bCXYxk"
@@ -93,7 +93,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
9393
type="checkbox"
9494
/>
9595
<div
96-
className="sc-AxhUy fPqOA-d"
96+
className="sc-AxhUy gbfYbF"
9797
>
9898
<svg
9999
className="sc-AxiKw bCXYxk"
@@ -147,7 +147,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
147147
type="checkbox"
148148
/>
149149
<div
150-
className="sc-AxhUy fPqOA-d"
150+
className="sc-AxhUy gbfYbF"
151151
>
152152
<svg
153153
className="sc-AxiKw bCXYxk"
@@ -201,7 +201,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
201201
type="checkbox"
202202
/>
203203
<div
204-
className="sc-AxhUy VqymF"
204+
className="sc-AxhUy juIZhB"
205205
>
206206
<svg
207207
className="sc-AxiKw bCXYxk"
@@ -255,7 +255,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
255255
type="checkbox"
256256
/>
257257
<div
258-
className="sc-AxhUy VqymF"
258+
className="sc-AxhUy juIZhB"
259259
>
260260
<svg
261261
className="sc-AxiKw bCXYxk"

src/js/routes/settings.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const Title = styled.h3`
4545
font-weight: 500;
4646
`;
4747

48-
const ButtonClose = styled.button`
48+
const ButtonClose = styled.a`
4949
border: 0;
5050
padding: 0.25rem;
5151
font-size: 2rem;

0 commit comments

Comments
 (0)