You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 1, 2022. It is now read-only.
I know we talked a little bit about PR names already, @mattdavis0351, but whether or not we validate the names of the learner's PR, I think we should definitely be suggesting meaningful PR names. This would help any learner better digest the work they're performing. If they want to accept the default Create my-workflow.yml or Update my-workflow.yml that's fine and their prerogative, but overall it would make a much nicer learning experience if their final repo had PRs that reflected the work they did, like Use GitHub-script to comment on a newly created issue and Use a workflow to put a new issue in triage.
The text was updated successfully, but these errors were encountered:
I agree with this, it was strictly left as default to speed up the testing of this course while also allowing for simpler validation of pull names in the config.
I still don't see why we can't just let them name it whatever we want and store than in a variable which we can reference if we need to fix mistakes
I still don't see why we can't just let them name it whatever we want and store than in a variable which we can reference if we need to fix mistakes
The more I work with the store the more I agree with this statement. I do think we should suggest meaningful titles even if we don't validate against them.
I know we talked a little bit about PR names already, @mattdavis0351, but whether or not we validate the names of the learner's PR, I think we should definitely be suggesting meaningful PR names. This would help any learner better digest the work they're performing. If they want to accept the default Create my-workflow.yml or Update my-workflow.yml that's fine and their prerogative, but overall it would make a much nicer learning experience if their final repo had PRs that reflected the work they did, like Use GitHub-script to comment on a newly created issue and Use a workflow to put a new issue in triage.
The text was updated successfully, but these errors were encountered: