Skip to content

False positive missing-required-inputs for app_location when action: "close" in Azure Static Web Apps deploy #609

Description

@57shiki

Bug report

Describe the bug

The extension reports a missing-required-inputs error for app_location on the
close_pull_request_job pattern recommended by Azure Static Web Apps. The workflow
runs successfully in CI — the error is a false positive.

Azure/static-web-apps-deploy@v1 marks app_location as required: true in its
action.yml, but the field is only meaningful when action: "upload". When
action: "close", the action ignores app_location entirely and completes without it.

Steps to reproduce

Use the standard close-PR job that Azure's own onboarding wizard generates, with GitHub Actions extension installed:

build_and_deploy_job:
    if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')
    runs-on: ubuntu-latest
    name: Build and Deploy Job
    permissions:
       id-token: write
       contents: read
    steps:
      - uses: actions/checkout@v4
        with:
          submodules: true
          lfs: false
      - name: Build And Deploy
        id: builddeploy
        uses: Azure/static-web-apps-deploy@v1
        with:
          azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN }}
          repo_token: ${{ secrets.GITHUB_TOKEN }}
          action: "upload"
          app_location: "/"
          #api_location: "api"
          output_location: "dist"

close_pull_request_job:
  if: github.event_name == 'pull_request' && github.event.action == 'closed'
  runs-on: ubuntu-latest
  name: Close Pull Request Job
  steps:
    - name: Close Pull Request
      id: closepullrequest
      uses: Azure/static-web-apps-deploy@v1
      with:
        azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN }}
        action: "close"

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Backlog 🗒

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions