Skip to content

Commit d6f72cf

Browse files
authored
Merge pull request #116 from github/linting-fixes
linting fixes
2 parents bcdaf83 + 911d080 commit d6f72cf

4 files changed

+15
-13
lines changed

test_time_to_merge.py

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
from time_to_merge import measure_time_to_merge
1616

17+
1718
class TestMeasureTimeToMerge(unittest.TestCase):
1819
"""Test suite for the measure_time_to_merge function."""
1920

test_time_to_ready_for_review.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
from time_to_ready_for_review import get_time_to_ready_for_review
1616

17+
1718
class TestGetTimeToReadyForReview(unittest.TestCase):
1819
"""Test suite for the get_time_to_ready_for_review function."""
1920

@@ -33,11 +34,11 @@ def test_get_time_to_ready_for_review_event(self):
3334
pull_request = MagicMock()
3435
pull_request.draft = False
3536
event = MagicMock()
36-
event.event = 'ready_for_review'
37+
event.event = "ready_for_review"
3738
event.created_at = datetime.fromisoformat("2021-01-01T00:00:00Z")
3839
issue = MagicMock()
39-
issue.issue.events.return_value=[event]
40-
40+
issue.issue.events.return_value = [event]
41+
4142
result = get_time_to_ready_for_review(issue, pull_request)
4243
expected_result = event.created_at
4344
self.assertEqual(result, expected_result)
@@ -47,10 +48,10 @@ def test_get_time_to_ready_for_review_no_event(self):
4748
pull_request = MagicMock()
4849
pull_request.draft = False
4950
event = MagicMock()
50-
event.event = 'foobar'
51+
event.event = "foobar"
5152
event.created_at = "2021-01-01T00:00:00Z"
5253
issue = MagicMock()
53-
issue.events.return_value=[event]
54+
issue.events.return_value = [event]
5455

5556
result = get_time_to_ready_for_review(issue, pull_request)
5657
expected_result = None

time_to_merge.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,19 @@
1212
1313
"""
1414
from datetime import datetime, timedelta
15-
from typing import List, Union
15+
from typing import Union
1616

1717
import github3
1818

19+
1920
def measure_time_to_merge(
20-
pull_request: github3.pulls.PullRequest,
21-
ready_for_review_at: Union[datetime, None]
21+
pull_request: github3.pulls.PullRequest, ready_for_review_at: Union[datetime, None]
2222
) -> Union[timedelta, None]:
2323
"""Measure the time it takes to merge a pull request.
2424
2525
Args:
2626
pull_request (github3.pulls.PullRequest): A GitHub pull request.
27-
ready_for_review_at (Union[timedelta, None]): When the PR was marked as ready for review
27+
ready_for_review_at (Union[timedelta, None]): When the PR was marked as ready for review
2828
2929
Returns:
3030
Union[datetime.timedelta, None]: The time it takes to close the issue.

time_to_ready_for_review.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919

2020
import github3
2121

22+
2223
def get_time_to_ready_for_review(
23-
issue: github3.issues.Issue,
24-
pull_request: github3.pulls.PullRequest
24+
issue: github3.issues.Issue, pull_request: github3.pulls.PullRequest
2525
) -> Union[datetime, None]:
2626
"""If a pull request was formerly a draft, get the time it was marked as ready
2727
for review
28-
28+
2929
Args:
3030
issue (github3.issues.Issue): A GitHub issue.
3131
pull_request (github3.pulls.PullRequest): A GitHub pull request.
@@ -38,7 +38,7 @@ def get_time_to_ready_for_review(
3838

3939
events = issue.issue.events(number=50)
4040
for event in events:
41-
if event.event == 'ready_for_review':
41+
if event.event == "ready_for_review":
4242
return event.created_at
4343

4444
return None

0 commit comments

Comments
 (0)