[pr-review] Daily PR Code Quality Review — 31867888921

[github-actions]

Summary

PR	Top Issue Count	Quality Signal
#52855 — Update CLI tools and Docker images for version check	N/A (draft, no diff yet)	⚪
#52854 — Fix MCP-server omission due to missing secrets	N/A (draft, no diff yet)	⚪
#52837 — Fix Claude Code CLI abnormal exit (code 159)	0	🟢
#52836 — Fix Design Decision Gate false failures	0	🟢
#52831 — Refactor objective mapping source-of-truth	0	🟢

Overall daily signal: 🟢 — all reviewable PRs (with non-empty diffs) show no notable code-quality issues.

Full Findings

#52855 — Update CLI tools and Docker images for version check (author: Copilot)

• Draft PR, no committed diff yet (bot is still working the plan) — nothing to review.

#52854 — Fix MCP-server omission due to missing secrets (author: Copilot)

• Draft PR, no committed diff yet — nothing to review.

#52837 — Fix Claude Code CLI abnormal exit code 159 (author: Copilot)

• Adds CRASH_SIGNAL_EXIT_CODES map and two small, single-purpose helper functions (isCrashSignalExitCode, crashSignalNameForExitCode), each with clear JSDoc doc comments.
• No oversized functions; changes are additive and localized to claude_harness.cjs.
• Good test coverage added in claude_harness.test.cjs covering both positive and negative cases for the new helpers and the updated shouldRetryWithContinue behavior, using real expect() assertions (not just logging).
• No missing error handling — this is control-flow/classification logic, not I/O.
• No issues found.

#52836 — Fix Design Decision Gate false failures caused by LLM invocation cap (author: Copilot)

• Adds a small guard clause to claude_harness.cjs, codex_harness.cjs, and copilot_harness.cjs to suppress a false "cancelled" verdict when safe-outputs already contain the expected result.
• Each harness variant has a corresponding new test with real assertions (expect(result.status).toBe(0), expect(callCount).toBe(1), stderr message checks) — not just logging.
• Bumped max-turns from 20 → 30 in design-decision-gate.md, with the corresponding .lock.yml regenerated (consistent with make recompile).
• No oversized functions; changes are small, mirrored across three harness files consistently.
• No issues found.

#52831 — Refactor objective mapping source-of-truth (author: Copilot)

• Removes ~140 lines of duplicated label/value constants (label_objective_mapping_constants.go), consolidating them into DefaultObjectiveMapping() as the single source of truth — reduces drift risk.
• Introduces two small unexported helpers, normalizeObjectiveLabel and objectiveValueForLabel, deduplicating repeated normalize-then-lookup logic across ComputeObjectiveValue, computeValueFirst, FilterObjectiveLabels, and HasObjectiveLabel. Both are unexported so Go doc-comment convention for exported symbols doesn't apply; no exported functions were added without doc comments.
• spec_test.go updated to test against DefaultObjectiveMapping() output directly instead of now-removed constants, with real assertions (assert.Equal, assert.NotContains) — no test regressions.
• README updated to replace the removed constants table with DefaultObjectiveMapping()'s label/value table, keeping docs in sync with code.
• No oversized functions; no missing error handling relevant to this refactor.
• No issues found.

Generated by 🖱️ Daily PR Code Quality Review · auto · 40.2 AIC · ⌖ 2.1 AIC · ⊞ 6.5K · ◷

• expires on Aug 15, 2026, 9:54 PM UTC-08:00