Rust: Allow for crate self-references in crate graph paths

hvitved · hvitved · commit fbab715cb6a1 · 2025-04-09T15:21:34.000+02:00
diff --git a/rust/ql/lib/codeql/rust/internal/PathResolution.qll b/rust/ql/lib/codeql/rust/internal/PathResolution.qll
@@ -764,6 +764,10 @@ private predicate crateDependencyEdge(ModuleLikeNode m, string name, CrateItemNo
     // entry/transitive source file
     m = c.getASourceFile()
   )
+  or
+  // paths inside the crate graph use the name of the crate itself as prefix,
+  // although that is not valid in Rust
+  dep = any(Crate c | name = c.getName() and m = c.getModule())
 }
 
 private predicate useTreeDeclares(UseTree tree, string name) {

Original file line number	Diff line number	Diff line change
`@@ -764,6 +764,10 @@ private predicate crateDependencyEdge(ModuleLikeNode m, string name, CrateItemNo`
`764`	`764`	`// entry/transitive source file`
`765`	`765`	`m = c.getASourceFile()`
`766`	`766`	`)`
	`767`	`+ or`
	`768`	`+ // paths inside the crate graph use the name of the crate itself as prefix,`
	`769`	`+ // although that is not valid in Rust`
	`770`	`+ dep = any(Crate c \| name = c.getName() and m = c.getModule())`
`767`	`771`	`}`
`768`	`772`
`769`	`773`	`private predicate useTreeDeclares(UseTree tree, string name) {`