Skip to content

Commit f11ae49

Browse files
committed
Dataflow: Fix a poor join-order.
1 parent a2aefc9 commit f11ae49

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3127,6 +3127,14 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
31273127
override predicate isSource() { sourceNode(node, state) }
31283128
}
31293129

3130+
bindingset[p, state, t, ap, stored]
3131+
pragma[inline_late]
3132+
private SummaryCtxSome mkSummaryCtxSome(
3133+
ParamNodeEx p, FlowState state, Typ t, Ap ap, TypOption stored
3134+
) {
3135+
result = TSummaryCtxSome(p, state, t, ap, stored)
3136+
}
3137+
31303138
pragma[nomagic]
31313139
private predicate fwdFlowInStep(
31323140
ArgNodeEx arg, ParamNodeEx p, FlowState state, Cc outercc, CcCall innercc,
@@ -3138,7 +3146,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
31383146
or
31393147
FwdFlowInThrough::fwdFlowIn(_, arg, _, p, state, outercc, innercc, outerSummaryCtx, t,
31403148
ap, stored, _) and
3141-
innerSummaryCtx = TSummaryCtxSome(p, state, t, ap, stored)
3149+
innerSummaryCtx = mkSummaryCtxSome(p, state, t, ap, stored)
31423150
}
31433151

31443152
pragma[nomagic]

0 commit comments

Comments
 (0)