Make module SsaInput private

owen-mc · owen-mc · commit e34a13722aa4 · 2026-03-24T11:57:02.000Z
Most other languages do this (but not ruby or rust).
diff --git a/go/ql/lib/semmle/go/dataflow/SsaImpl.qll b/go/ql/lib/semmle/go/dataflow/SsaImpl.qll
@@ -76,8 +76,7 @@ private module Internal {
     any(IR::Instruction def | def.writes(v, _)).getRoot() != v.getDeclaringFunction()
   }
 
-  cached
-  module SsaInput implements SsaImplCommon::InputSig<Location, BasicBlock> {
+  private module SsaInput implements SsaImplCommon::InputSig<Location, BasicBlock> {
     class SourceVariable = SsaSourceVariable;
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,7 @@ private module Internal {`
`76`	`76`	`any(IR::Instruction def \| def.writes(v, _)).getRoot() != v.getDeclaringFunction()`
`77`	`77`	`}`
`78`	`78`
`79`		`- cached`
`80`		`- module SsaInput implements SsaImplCommon::InputSig<Location, BasicBlock> {`
	`79`	`+ private module SsaInput implements SsaImplCommon::InputSig<Location, BasicBlock> {`
`81`	`80`	`class SourceVariable = SsaSourceVariable;`
`82`	`81`
`83`	`82`	`/**`