C++: Simplify cpp/boost/tls-settings-misconfiguration

jketema · jketema · commit adfb3c3d500d · 2024-03-22T11:22:11.000+01:00
diff --git a/cpp/ql/src/Likely Bugs/Protocols/TlsSettingsMisconfiguration.ql b/cpp/ql/src/Likely Bugs/Protocols/TlsSettingsMisconfiguration.ql
@@ -43,10 +43,9 @@ predicate isOptionSet(ConstructorCall cc, int flag, FunctionCall fcSetOptions) {
     ExistsAnyFlow::flow(source, sink) and
     f.getACallToThisFunction() = fcSetOptions and
     contextSetOptions = fcSetOptions.getQualifier() and
-    forall(Expr optionArgument, Expr optionArgumentSource |
+    forex(Expr optionArgument |
       optionArgument = fcSetOptions.getArgument(0) and
-      BoostorgAsio::SslOptionFlow::flow(DataFlow::exprNode(optionArgumentSource),
-        DataFlow::exprNode(optionArgument))
+      BoostorgAsio::SslOptionFlow::flowTo(DataFlow::exprNode(optionArgument))
     |
       optionArgument.getValue().toInt().bitShiftRight(16).bitAnd(flag) = flag
     )

Original file line number	Diff line number	Diff line change
`@@ -43,10 +43,9 @@ predicate isOptionSet(ConstructorCall cc, int flag, FunctionCall fcSetOptions) {`
`43`	`43`	`ExistsAnyFlow::flow(source, sink) and`
`44`	`44`	`f.getACallToThisFunction() = fcSetOptions and`
`45`	`45`	`contextSetOptions = fcSetOptions.getQualifier() and`
`46`		`- forall(Expr optionArgument, Expr optionArgumentSource \|`
	`46`	`+ forex(Expr optionArgument \|`
`47`	`47`	`optionArgument = fcSetOptions.getArgument(0) and`
`48`		`- BoostorgAsio::SslOptionFlow::flow(DataFlow::exprNode(optionArgumentSource),`
`49`		`- DataFlow::exprNode(optionArgument))`
	`48`	`+ BoostorgAsio::SslOptionFlow::flowTo(DataFlow::exprNode(optionArgument))`
`50`	`49`	`\|`
`51`	`50`	`optionArgument.getValue().toInt().bitShiftRight(16).bitAnd(flag) = flag`
`52`	`51`	`)`