Ruby: use DataFlow::CallNode#getBlock to remove a cast

alexrford · alexrford · commit 3262a14f2250 · 2021-12-14T13:23:38.000Z
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/Rails.qll b/ruby/ql/lib/codeql/ruby/frameworks/Rails.qll
@@ -68,7 +68,7 @@ private class ConfigSourceNode extends DataFlow::LocalSourceNode {
       configCall = this.asExpr().getExpr()
     |
       configureCallNode = getAConfigureCallNode() and
-      block = configureCallNode.asExpr().getExpr().(MethodCall).getBlock() and
+      block = configureCallNode.getBlock().asExpr().getExpr() and
       configCall.getParent+() = block and
       configCall.getMethodName() = "config"
     )

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ private class ConfigSourceNode extends DataFlow::LocalSourceNode {`
`68`	`68`	`configCall = this.asExpr().getExpr()`
`69`	`69`	`\|`
`70`	`70`	`configureCallNode = getAConfigureCallNode() and`
`71`		`- block = configureCallNode.asExpr().getExpr().(MethodCall).getBlock() and`
	`71`	`+ block = configureCallNode.getBlock().asExpr().getExpr() and`
`72`	`72`	`configCall.getParent+() = block and`
`73`	`73`	`configCall.getMethodName() = "config"`
`74`	`74`	`)`