Skip to content

Commit 1e32e84

Browse files
mbgmbg
authored
Merge pull request #17369 from smowton/smowton/admin/aliasing-tests
Go: add tests regarding type aliasing
2 parents e542d66 + fe9d879 commit 1e32e84

File tree

9 files changed

+220
-0
lines changed

9 files changed

+220
-0
lines changed

‎go/ql/test/library-tests/semmle/go/aliases/InterfaceImpls/test.expected

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
callTargets
2+
| test.go:48:2:48:24 | call to ImplementMe | test.go:12:1:12:69 | function declaration | ImplementMe |
3+
| test.go:48:2:48:24 | call to ImplementMe | test.go:17:1:17:64 | function declaration | ImplementMe |
4+
| test.go:48:2:48:24 | call to ImplementMe | test.go:24:1:24:53 | function declaration | ImplementMe |
5+
| test.go:48:2:48:24 | call to ImplementMe | test.go:31:1:31:59 | function declaration | ImplementMe |
6+
| test.go:48:2:48:24 | call to ImplementMe | test.go:38:1:38:71 | function declaration | ImplementMe |
7+
| test.go:48:2:48:24 | call to ImplementMe | test.go:45:1:45:69 | function declaration | ImplementMe |
8+
#select
9+
| file://:0:0:0:0 | basic interface type | file://:0:0:0:0 | basic interface type |
10+
| file://:0:0:0:0 | basic interface type | test.go:10:6:10:10 | Impl1 |
11+
| file://:0:0:0:0 | basic interface type | test.go:15:6:15:10 | Impl2 |
12+
| file://:0:0:0:0 | basic interface type | test.go:20:6:20:10 | Impl3 |
13+
| file://:0:0:0:0 | basic interface type | test.go:27:6:27:10 | Impl4 |
14+
| file://:0:0:0:0 | basic interface type | test.go:34:6:34:10 | Impl5 |
15+
| file://:0:0:0:0 | basic interface type | test.go:41:6:41:10 | Impl6 |

‎go/ql/test/library-tests/semmle/go/aliases/InterfaceImpls/test.go

+49
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
package intfs
2+
3+
type IntAlias = int
4+
5+
type Target = interface {
6+
ImplementMe(callable func(struct{ x IntAlias }))
7+
}
8+
9+
// Simple direct implementation
10+
type Impl1 struct{}
11+
12+
func (recv Impl1) ImplementMe(callable func(struct{ x IntAlias })) {}
13+
14+
// Implementation via unaliasing
15+
type Impl2 struct{}
16+
17+
func (recv Impl2) ImplementMe(callable func(struct{ x int })) {}
18+
19+
// Implementation via top-level aliasing
20+
type Impl3 struct{}
21+
22+
type Impl3Alias = func(struct{ x IntAlias })
23+
24+
func (recv Impl3) ImplementMe(callable Impl3Alias) {}
25+
26+
// Implementation via aliasing the struct
27+
type Impl4 struct{}
28+
29+
type Impl4Alias = struct{ x IntAlias }
30+
31+
func (recv Impl4) ImplementMe(callable func(Impl4Alias)) {}
32+
33+
// Implementation via aliasing the struct member
34+
type Impl5 struct{}
35+
36+
type Impl5Alias = IntAlias
37+
38+
func (recv Impl5) ImplementMe(callable func(struct{ x Impl5Alias })) {}
39+
40+
// Implementation via defining the method on an alias
41+
type Impl6 struct{}
42+
43+
type Impl6Alias = Impl6
44+
45+
func (recv Impl6Alias) ImplementMe(callable func(struct{ x int })) {}
46+
47+
func Caller(target Target) {
48+
target.ImplementMe(nil)
49+
}

‎go/ql/test/library-tests/semmle/go/aliases/InterfaceImpls/test.ql

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import go
2+
3+
query predicate callTargets(DataFlow::CallNode cn, FuncDef target, string targetName) {
4+
target = cn.getACallee() and targetName = target.getName()
5+
}
6+
7+
from InterfaceType i, Type impl
8+
where
9+
i.hasMethod("ImplementMe", _) and
10+
impl.implements(i)
11+
select i, impl

‎go/ql/test/library-tests/semmle/go/aliases/MethodDefs/methods.go

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
package aliases
2+
3+
type IntAlias = int
4+
5+
type S1 = struct{ x int }
6+
type S2 = struct{ x IntAlias }
7+
8+
type I1 = interface{ F(int) }
9+
type I2 = interface{ F(IntAlias) }
10+
type I3 = interface{ F(S1) }
11+
type I4 = interface{ F(S2) }
12+
13+
func Test1(param1 I1, param2 I3, arg int) {
14+
param1.F(arg)
15+
param2.F(S1{arg})
16+
}

‎go/ql/test/library-tests/semmle/go/aliases/MethodDefs/test.expected

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
distinctDefinedFs
2+
| 2 |
3+
declaredEntities
4+
| methods.go:3:6:3:13 | IntAlias (1 declaration sites) |
5+
| methods.go:5:6:5:7 | S1 (1 declaration sites) |
6+
| methods.go:5:19:5:19 | x (2 declaration sites) |
7+
| methods.go:6:6:6:7 | S2 (1 declaration sites) |
8+
| methods.go:6:19:6:19 | x (2 declaration sites) |
9+
| methods.go:8:6:8:7 | I1 (1 declaration sites) |
10+
| methods.go:8:22:8:22 | F (2 declaration sites) |
11+
| methods.go:9:6:9:7 | I2 (1 declaration sites) |
12+
| methods.go:9:22:9:22 | F (2 declaration sites) |
13+
| methods.go:10:6:10:7 | I3 (1 declaration sites) |
14+
| methods.go:10:22:10:22 | F (2 declaration sites) |
15+
| methods.go:11:6:11:7 | I4 (1 declaration sites) |
16+
| methods.go:11:22:11:22 | F (2 declaration sites) |
17+
| methods.go:13:6:13:10 | Test1 (1 declaration sites) |
18+
| methods.go:13:12:13:17 | param1 (1 declaration sites) |
19+
| methods.go:13:23:13:28 | param2 (1 declaration sites) |
20+
| methods.go:13:34:13:36 | arg (1 declaration sites) |

‎go/ql/test/library-tests/semmle/go/aliases/MethodDefs/test.ql

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
import go
2+
3+
newtype TEntityWithDeclInfo =
4+
MkEntityWithDeclInfo(Entity e, int nDecls) { nDecls = count(e.getDeclaration()) and nDecls > 0 }
5+
6+
class EntityWithDeclInfo extends TEntityWithDeclInfo {
7+
Entity e;
8+
int nDecls;
9+
10+
EntityWithDeclInfo() { this = MkEntityWithDeclInfo(e, nDecls) }
11+
12+
string toString() { result = e.toString() + " (" + nDecls + " declaration sites)" }
13+
14+
predicate hasLocationInfo(
15+
string filepath, int startline, int startcolumn, int endline, int endcolumn
16+
) {
17+
e.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
18+
}
19+
}
20+
21+
query predicate distinctDefinedFs(int ct) { ct = count(DeclaredFunction e | e.toString() = "F") }
22+
23+
query predicate declaredEntities(EntityWithDeclInfo e) { any() }

‎go/ql/test/library-tests/semmle/go/aliases/defsuses/defsuses.go

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
package aliases
2+
3+
type IntAlias = int
4+
5+
type S1 = struct{ x int }
6+
type S2 = struct{ x IntAlias }
7+
8+
func Test1() int {
9+
obj := S1{1}
10+
obj.x = 2
11+
12+
var ptr *S2
13+
ptr = &obj
14+
15+
return ptr.x
16+
}

‎go/ql/test/library-tests/semmle/go/aliases/defsuses/test.expected

+33
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
lowLevelDefs
2+
| defsuses.go:3:6:3:13 | IntAlias | defsuses.go:3:6:3:13 | IntAlias (1 declaration sites) |
3+
| defsuses.go:5:6:5:7 | S1 | defsuses.go:5:6:5:7 | S1 (1 declaration sites) |
4+
| defsuses.go:5:19:5:19 | x | defsuses.go:5:19:5:19 | x (2 declaration sites) |
5+
| defsuses.go:5:19:5:19 | x | defsuses.go:6:19:6:19 | x (2 declaration sites) |
6+
| defsuses.go:6:6:6:7 | S2 | defsuses.go:6:6:6:7 | S2 (1 declaration sites) |
7+
| defsuses.go:6:19:6:19 | x | defsuses.go:5:19:5:19 | x (2 declaration sites) |
8+
| defsuses.go:6:19:6:19 | x | defsuses.go:6:19:6:19 | x (2 declaration sites) |
9+
| defsuses.go:8:6:8:10 | Test1 | defsuses.go:8:6:8:10 | Test1 (1 declaration sites) |
10+
| defsuses.go:9:2:9:4 | obj | defsuses.go:9:2:9:4 | obj (1 declaration sites) |
11+
| defsuses.go:12:6:12:8 | ptr | defsuses.go:12:6:12:8 | ptr (1 declaration sites) |
12+
lowLevelUses
13+
| defsuses.go:3:17:3:19 | int | file://:0:0:0:0 | int (0 declaration sites) |
14+
| defsuses.go:5:21:5:23 | int | file://:0:0:0:0 | int (0 declaration sites) |
15+
| defsuses.go:6:21:6:28 | IntAlias | defsuses.go:3:6:3:13 | IntAlias (1 declaration sites) |
16+
| defsuses.go:8:14:8:16 | int | file://:0:0:0:0 | int (0 declaration sites) |
17+
| defsuses.go:9:9:9:10 | S1 | defsuses.go:5:6:5:7 | S1 (1 declaration sites) |
18+
| defsuses.go:10:2:10:4 | obj | defsuses.go:9:2:9:4 | obj (1 declaration sites) |
19+
| defsuses.go:10:6:10:6 | x | defsuses.go:5:19:5:19 | x (2 declaration sites) |
20+
| defsuses.go:10:6:10:6 | x | defsuses.go:6:19:6:19 | x (2 declaration sites) |
21+
| defsuses.go:12:11:12:12 | S2 | defsuses.go:6:6:6:7 | S2 (1 declaration sites) |
22+
| defsuses.go:13:2:13:4 | ptr | defsuses.go:12:6:12:8 | ptr (1 declaration sites) |
23+
| defsuses.go:13:9:13:11 | obj | defsuses.go:9:2:9:4 | obj (1 declaration sites) |
24+
| defsuses.go:15:9:15:11 | ptr | defsuses.go:12:6:12:8 | ptr (1 declaration sites) |
25+
| defsuses.go:15:13:15:13 | x | defsuses.go:5:19:5:19 | x (2 declaration sites) |
26+
| defsuses.go:15:13:15:13 | x | defsuses.go:6:19:6:19 | x (2 declaration sites) |
27+
distinctDefinedXs
28+
| 1 |
29+
distinctUsedXs
30+
| 1 |
31+
fieldUseUsePairs
32+
| defsuses.go:10:6:10:6 | x | defsuses.go:15:13:15:13 | x |
33+
| defsuses.go:15:13:15:13 | x | defsuses.go:10:6:10:6 | x |

‎go/ql/test/library-tests/semmle/go/aliases/defsuses/test.ql

+37
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
import go
2+
3+
newtype TEntityWithDeclInfo = MkEntityWithDeclInfo(Entity e)
4+
5+
class EntityWithDeclInfo extends TEntityWithDeclInfo {
6+
Entity e;
7+
8+
EntityWithDeclInfo() { this = MkEntityWithDeclInfo(e) }
9+
10+
string toString() {
11+
result = e.toString() + " (" + count(e.getDeclaration()) + " declaration sites)"
12+
}
13+
14+
predicate hasLocationInfo(
15+
string filepath, int startline, int startcolumn, int endline, int endcolumn
16+
) {
17+
e.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
18+
}
19+
}
20+
21+
query predicate lowLevelDefs(Ident i, EntityWithDeclInfo ewrapped) {
22+
exists(Entity e | ewrapped = MkEntityWithDeclInfo(e) | defs(i, e))
23+
}
24+
25+
query predicate lowLevelUses(Ident i, EntityWithDeclInfo ewrapped) {
26+
exists(Entity e | ewrapped = MkEntityWithDeclInfo(e) | uses(i, e))
27+
}
28+
29+
query predicate distinctDefinedXs(int ct) {
30+
ct = count(Entity e | defs(_, e) and e.toString() = "x")
31+
}
32+
33+
query predicate distinctUsedXs(int ct) { ct = count(Entity e | uses(_, e) and e.toString() = "x") }
34+
35+
query predicate fieldUseUsePairs(Ident i1, Ident i2) {
36+
exists(Field e | uses(i1, e) and uses(i2, e) and i1 != i2)
37+
}

0 commit comments

Comments
 (0)