Skip to content

Commit 171a846

Browse files
committed
Applied copilot suggestion.
1 parent 5ec71ab commit 171a846

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/TaintedPath.expected

+3-3
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
| handlebars.js:11:32:11:39 | filePath | handlebars.js:29:46:29:60 | req.params.path | handlebars.js:11:32:11:39 | filePath | This path depends on a $@. | handlebars.js:29:46:29:60 | req.params.path | user-provided value |
5353
| handlebars.js:15:25:15:32 | filePath | handlebars.js:43:15:43:29 | req.params.path | handlebars.js:15:25:15:32 | filePath | This path depends on a $@. | handlebars.js:43:15:43:29 | req.params.path | user-provided value |
5454
| hapi.js:15:44:15:51 | filepath | hapi.js:14:30:14:51 | request ... ilepath | hapi.js:15:44:15:51 | filepath | This path depends on a $@. | hapi.js:14:30:14:51 | request ... ilepath | user-provided value |
55-
| make-dir.js:9:19:9:22 | file | make-dir.js:7:18:7:31 | req.query.file | make-dir.js:9:19:9:22 | file | This path depends on a $@. | make-dir.js:7:18:7:31 | req.query.file | user-provided value |
55+
| make-dir.js:9:25:9:28 | file | make-dir.js:7:18:7:31 | req.query.file | make-dir.js:9:25:9:28 | file | This path depends on a $@. | make-dir.js:7:18:7:31 | req.query.file | user-provided value |
5656
| make-dir.js:10:23:10:26 | file | make-dir.js:7:18:7:31 | req.query.file | make-dir.js:10:23:10:26 | file | This path depends on a $@. | make-dir.js:7:18:7:31 | req.query.file | user-provided value |
5757
| mkdirp.js:11:12:11:18 | dirPath | mkdirp.js:9:42:9:59 | req.query.filename | mkdirp.js:11:12:11:18 | dirPath | This path depends on a $@. | mkdirp.js:9:42:9:59 | req.query.filename | user-provided value |
5858
| mkdirp.js:12:17:12:23 | dirPath | mkdirp.js:9:42:9:59 | req.query.filename | mkdirp.js:12:17:12:23 | dirPath | This path depends on a $@. | mkdirp.js:9:42:9:59 | req.query.filename | user-provided value |
@@ -405,7 +405,7 @@ edges
405405
| handlebars.js:43:15:43:29 | req.params.path | handlebars.js:13:73:13:80 | filePath | provenance | |
406406
| hapi.js:14:19:14:51 | filepath | hapi.js:15:44:15:51 | filepath | provenance | |
407407
| hapi.js:14:30:14:51 | request ... ilepath | hapi.js:14:19:14:51 | filepath | provenance | |
408-
| make-dir.js:7:11:7:31 | file | make-dir.js:9:19:9:22 | file | provenance | |
408+
| make-dir.js:7:11:7:31 | file | make-dir.js:9:25:9:28 | file | provenance | |
409409
| make-dir.js:7:11:7:31 | file | make-dir.js:10:23:10:26 | file | provenance | |
410410
| make-dir.js:7:18:7:31 | req.query.file | make-dir.js:7:11:7:31 | file | provenance | |
411411
| mkdirp.js:9:11:9:76 | dirPath | mkdirp.js:11:12:11:18 | dirPath | provenance | |
@@ -956,7 +956,7 @@ nodes
956956
| hapi.js:15:44:15:51 | filepath | semmle.label | filepath |
957957
| make-dir.js:7:11:7:31 | file | semmle.label | file |
958958
| make-dir.js:7:18:7:31 | req.query.file | semmle.label | req.query.file |
959-
| make-dir.js:9:19:9:22 | file | semmle.label | file |
959+
| make-dir.js:9:25:9:28 | file | semmle.label | file |
960960
| make-dir.js:10:23:10:26 | file | semmle.label | file |
961961
| mkdirp.js:9:11:9:76 | dirPath | semmle.label | dirPath |
962962
| mkdirp.js:9:21:9:76 | path.jo ... ltDir') | semmle.label | path.jo ... ltDir') |

javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/make-dir.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import { makeDirectory, makeDirectorySync } from 'make-dir';
33
const express = require('express');
44
const app = express();
55

6-
app.get('/makedir', (req, res) => {
6+
app.get('/makedir', async (req, res) => {
77
const file = req.query.file; // $ Source
88

9-
makeDirectory(file); // $ Alert
9+
await makeDirectory(file); // $ Alert
1010
makeDirectorySync(file); // $ Alert
1111
});

0 commit comments

Comments
 (0)