Make test easier to understand

owen-mc · owen-mc · commit 05fb22e8fff8 · 2025-01-27T14:10:19.000Z
diff --git a/java/ql/test/query-tests/security/CWE-079/semmle/tests/SpringXSS.java b/java/ql/test/query-tests/security/CWE-079/semmle/tests/SpringXSS.java
@@ -17,7 +17,7 @@ public static ResponseEntity<String> specificContentType(boolean safeContentType
 
     ResponseEntity.BodyBuilder builder = ResponseEntity.ok();
 
-    if(safeContentType) {
+    if(!safeContentType) {
       if(chainDirectly) {
         return builder.contentType(MediaType.TEXT_HTML).body(userControlled); // $xss
       }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ public static ResponseEntity<String> specificContentType(boolean safeContentType`
`17`	`17`
`18`	`18`	`ResponseEntity.BodyBuilder builder = ResponseEntity.ok();`
`19`	`19`
`20`		`- if(safeContentType) {`
	`20`	`+ if(!safeContentType) {`
`21`	`21`	`if(chainDirectly) {`
`22`	`22`	`return builder.contentType(MediaType.TEXT_HTML).body(userControlled); // $xss`
`23`	`23`	`}`