Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A3-1-5: Consider whether to exclude =default members #442

Closed
lcartey opened this issue Nov 20, 2023 · 1 comment
Closed

A3-1-5: Consider whether to exclude =default members #442

lcartey opened this issue Nov 20, 2023 · 1 comment
Assignees
@rvermeulen
Labels
Difficulty-Medium A false positive or false negative report which is expected to take 1-5 days effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards

Comments

@lcartey
Copy link
Collaborator

lcartey commented Nov 20, 2023

Affected rules

  • A3-1-5

Description

=default members may not be trivial, and it may be hard to determine whether they are not included in the class body to allow forward declaration in the header.
@lcartey lcartey added false positive/false negative An issue related to observed false positives or false negatives. Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address Impact-Medium Difficulty-Medium A false positive or false negative report which is expected to take 1-5 days effort to address and removed Difficulty-Low A false positive or false negative report which is expected to take <1 day effort to address labels Nov 20, 2023
@rvermeulen rvermeulen self-assigned this Jan 23, 2024
@rvermeulen rvermeulen moved this from Triaged to Scheduled in Coding Standards Public Development Board Jan 23, 2024
@ravikprasad ravikprasad added the user-report Issue reported by an end user of CodeQL Coding Standards label Feb 20, 2024
@rvermeulen rvermeulen moved this from Scheduled to WontImplement/CompilerChecked in Coding Standards Public Development Board Feb 20, 2024
@rvermeulen rvermeulen moved this from WontImplement/CompilerChecked to In Progress in Coding Standards Public Development Board Feb 20, 2024
@rvermeulen
Copy link
Collaborator

This issue is superseded by #481. In #481 we will reduce the scope the implementation to only look at definitions in a class and no longer alert on definitions outside of a class that match the conditions to be in the class definition.

@rvermeulen rvermeulen moved this from Done to WontImplement/CompilerChecked in Coding Standards Public Development Board Feb 20, 2024
@lcartey lcartey moved this from WontImplement/CompilerChecked to Closed (Duplicate) in Coding Standards Public Development Board Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvermeulen rvermeulen

Labels
Difficulty-Medium A false positive or false negative report which is expected to take 1-5 days effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-Medium user-report Issue reported by an end user of CodeQL Coding Standards
Projects
Coding Standards Public Development Board
Status: Closed (Duplicate)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rvermeulen @lcartey @ravikprasad