Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit c53fa14

Browse files
committed
Fix displaying errors in GitHub pane.
#1787 refactored `InfoPanel` but didn't update `GitHubPaneView` with its new behavior. So: - Don't initialy set `infoPanel.Visibility` to `Collapsed`: `InfoPanel` will handle this itself - Set `ShowCloseButton` to show the `x` button to close the error Fixes #2172 Fixes #2058
1 parent 11c9d34 commit c53fa14

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

src/GitHub.VisualStudio.UI/Views/GitHubPane/GitHubPaneView.xaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
<uic:InfoPanel x:Name="infoPanel"
4444
DockPanel.Dock="Top"
4545
Message="{Binding Message}"
46+
ShowCloseButton="True"
4647
VerticalAlignment="Top"/>
4748
<StackPanel DockPanel.Dock="Top"
4849
Margin="6,9,9,5"

src/GitHub.VisualStudio.UI/Views/GitHubPane/GitHubPaneView.xaml.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ public GitHubPaneView(INotificationDispatcher notifications)
2727

2828
this.WhenActivated(d =>
2929
{
30-
infoPanel.Visibility = Visibility.Collapsed;
3130
d(notifications.Listen()
3231
.ObserveOnDispatcher(DispatcherPriority.Normal)
3332
.Subscribe(n =>

0 commit comments

Comments
 (0)