Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 594da08

Browse files
author
Steven Kirk
committed
Keep validation adornment visibility up to date
The `ShowValidateError` method wasn't getting called to update the validation adorner when `ValidationMessage.ShowError` changes independent of a `TextChanged` or focus event. I'm not sure if this should be done here or in the `WhenAny` above which updates `ShowError` - I've put it here as that's where the existing call to ShowValidateError is.
1 parent e7dc701 commit 594da08

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/GitHub.UI.Reactive/Controls/Validation/ValidationMessage.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ public ValidationMessage()
3333
.Do(CreateBinding)
3434
.Select(control =>
3535
Observable.Merge(
36+
this.WhenAnyValue(x => x.ShowError),
3637
control.Events().TextChanged
3738
.Throttle(TimeSpan.FromSeconds(ShowError ? defaultTextChangeThrottle : TextChangeThrottle),
3839
RxApp.MainThreadScheduler)

0 commit comments

Comments
 (0)