Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 427f206

Browse files
committed
Use Merge instead of Amb on login control.
Fixes #309. `Observable.Amb` "emits all of the items from only the first of these Observables to emit an item or notification". This means that if the user tries to login first to .com with an invalid login, then tries to login to enterprise with a valid login the login from enterprise will be ignored because the .com observable fired first. Instead use `Observable.Merge` which will emit authentication results from both in any order.
1 parent 7a6586f commit 427f206

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/GitHub.App/ViewModels/LoginControlViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public LoginControlViewModel(
4545

4646
}).ToProperty(this, x => x.LoginMode);
4747

48-
AuthenticationResults = Observable.Amb(
48+
AuthenticationResults = Observable.Merge(
4949
loginToGitHubViewModel.Login,
5050
EnterpriseLogin.Login);
5151
CancelCommand = ReactiveCommand.Create();

0 commit comments

Comments
 (0)