Merge pull request #270 from github/fixes/fix-horrible-cache-leak

Cache blob caches

Author: haacked

src/GitHub.App/Factories/SqlitePersistentBlobCacheFactory.cs

@@ -2,6 +2,7 @@
 using Akavache.Sqlite3;
 using NLog;
 using System;
+using System.Collections.Generic;
 using System.ComponentModel.Composition;
 
 namespace GitHub.Factories
@@ -11,14 +12,19 @@ namespace GitHub.Factories
     public class SqlitePersistentBlobCacheFactory : IBlobCacheFactory
     {
         static readonly Logger log = LogManager.GetCurrentClassLogger();
+        Dictionary<string, IBlobCache> cache = new Dictionary<string, IBlobCache>();
 
         public IBlobCache CreateBlobCache(string path)
         {
             Guard.ArgumentNotEmptyString(path, nameof(path));
+            if (cache.ContainsKey(path))
+                return cache[path];
 
             try
             {
-                return new SQLitePersistentBlobCache(path);
+                var c = new SQLitePersistentBlobCache(path);
+                cache.Add(path, c);
+                return c;
             }
             catch(Exception ex)
             {