Set the pull request WebUrl and OpenOnGitHub

Make hash-link at top pull request page open on GitHub.

Author: jcansdale

src/GitHub.App/ViewModels/Documents/PullRequestPageViewModel.cs

@@ -23,6 +23,7 @@ public class PullRequestPageViewModel : PullRequestViewModelBase, IPullRequestPa
         readonly IPullRequestService service;
         readonly IPullRequestSessionManager sessionManager;
         readonly ITeamExplorerServices teServices;
+        readonly IVisualStudioBrowser visualStudioBrowser;
         readonly IUsageTracker usageTracker;
         ActorModel currentUserModel;
         ReactiveList<IViewModel> timeline = new ReactiveList<IViewModel>();
@@ -37,22 +38,26 @@ public PullRequestPageViewModel(
             IPullRequestService service,
             IPullRequestSessionManager sessionManager,
             ITeamExplorerServices teServices,
+            IVisualStudioBrowser visualStudioBrowser,
             IUsageTracker usageTracker)
         {
             Guard.ArgumentNotNull(factory, nameof(factory));
             Guard.ArgumentNotNull(service, nameof(service));
             Guard.ArgumentNotNull(sessionManager, nameof(sessionManager));
+            Guard.ArgumentNotNull(visualStudioBrowser, nameof(visualStudioBrowser));
             Guard.ArgumentNotNull(teServices, nameof(teServices));
 
             this.factory = factory;
             this.service = service;
             this.sessionManager = sessionManager;
             this.teServices = teServices;
+            this.visualStudioBrowser = visualStudioBrowser;
             this.usageTracker = usageTracker;
 
             timeline.ItemsRemoved.Subscribe(TimelineItemRemoved);
 
             ShowCommit = ReactiveCommand.CreateFromTask<string>(DoShowCommit);
+            OpenOnGitHub = ReactiveCommand.Create(DoOpenOnGitHub);
         }
 
         /// <inheritdoc/>
@@ -198,6 +203,11 @@ async Task DoShowCommit(string oid)
             teServices.ShowCommitDetails(oid);
         }
 
+        void DoOpenOnGitHub()
+        {
+            visualStudioBrowser.OpenUrl(WebUrl);
+        }
+
         void TimelineItemRemoved(IViewModel item)
         {
             (item as IDisposable)?.Dispose();

src/GitHub.App/ViewModels/IssueishViewModel.cs

@@ -63,11 +63,11 @@ public string Title
         public Uri WebUrl
         {
             get { return webUrl; }
-            private set { this.RaiseAndSetIfChanged(ref webUrl, value); }
+            protected set { this.RaiseAndSetIfChanged(ref webUrl, value); }
         }
 
         /// <inheritdoc/>
-        public ReactiveCommand<Unit, Unit> OpenOnGitHub { get; }
+        public ReactiveCommand<Unit, Unit> OpenOnGitHub { get; protected set; }
 
         protected Task InitializeAsync(
             RemoteRepositoryModel repository,

src/GitHub.App/ViewModels/PullRequestViewModelBase.cs

@@ -1,6 +1,7 @@
 using System;
 using System.ComponentModel.Composition;
 using System.Threading.Tasks;
+using GitHub.Extensions;
 using GitHub.Logging;
 using GitHub.Models;
 using ReactiveUI;
@@ -59,6 +60,7 @@ protected virtual async Task InitializeAsync(
             State = model.State;
             SourceBranchDisplayName = GetBranchDisplayName(fork, model.HeadRepositoryOwner, model.HeadRefName);
             TargetBranchDisplayName = GetBranchDisplayName(fork, model.BaseRepositoryOwner, model.BaseRefName);
+            WebUrl = localRepository.CloneUrl.ToRepositoryUrl().Append("pull/" + Number);
         }
 
         static string GetBranchDisplayName(bool isFromFork, string owner, string label)