Skip to content

Provide existing SSM parameters for github_app secrets to avoid storing values in Terraform state #4420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jo-koe opened this issue Feb 12, 2025 · 2 comments

Comments

@jo-koe
Copy link

jo-koe commented Feb 12, 2025

We would like to have the option to provide existing SSM Parameters for the github_app.key_base64 and github_app.id inputs so that the values for these secrets are not necessarily stored in the Terraform state. (The input github_app.webhook_secret can be managed via the module soon so we've not mentioned it: #4392).

We've seen that this topic was discussed already several times e.g. #2936, #2183, #587. Also we do understand that this would require some resource management outside of this module which is maybe not wanted. Anyway we just wanted to ask for it again to get a clear answer.

Thanks!

@npalm
Copy link
Member

npalm commented Feb 20, 2025

Quick update, the PR is almost ready. Some last minor remarks need to processed.

@npalm
Copy link
Member

npalm commented Mar 5, 2025

Option added via PR #4335

@npalm npalm closed this as completed Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants