Skip to content

Commit 79ff57f

Browse files
committed
pack-bitmap: make *_bitmap_filename() file-scope static
These two functions come up with the filename that hold pack and midx bitmap files, given the name of a packfile, which is done as an internal implementation detail of opening these auxiliary files while using a packfile. Make them file-scope static, as no external callers have any business calling them. Signed-off-by: Junio C Hamano <[email protected]>
1 parent f99c0fe commit 79ff57f

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

pack-bitmap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ static int load_bitmap_entries_v1(struct bitmap_index *index)
365365
return 0;
366366
}
367367

368-
char *midx_bitmap_filename(struct multi_pack_index *midx)
368+
static char *midx_bitmap_filename(struct multi_pack_index *midx)
369369
{
370370
struct strbuf buf = STRBUF_INIT;
371371
get_midx_filename_ext(&buf, midx->object_dir, get_midx_checksum(midx),
@@ -374,7 +374,7 @@ char *midx_bitmap_filename(struct multi_pack_index *midx)
374374
return strbuf_detach(&buf, NULL);
375375
}
376376

377-
char *pack_bitmap_filename(struct packed_git *p)
377+
static char *pack_bitmap_filename(struct packed_git *p)
378378
{
379379
size_t len;
380380

pack-bitmap.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,6 @@ void bitmap_writer_finish(struct bitmap_writer *writer,
155155
const char *filename,
156156
uint16_t options);
157157
void bitmap_writer_free(struct bitmap_writer *writer);
158-
char *midx_bitmap_filename(struct multi_pack_index *midx);
159-
char *pack_bitmap_filename(struct packed_git *p);
160158

161159
int bitmap_is_midx(struct bitmap_index *bitmap_git);
162160

0 commit comments

Comments
 (0)