Skip to content

Commit 2377274

Browse files
committed
max_tree_depth: lower it for clangarm64 on Windows
Just as in b64d78a (max_tree_depth: lower it for MSVC to avoid stack overflows, 2023-11-01), I encountered the same problem with the clang builds on Windows/ARM64. The symptom is an exit code 127 when t6700 tries to verify that `git archive big` fails. This exit code is reserved on Unix/Linux to mean "command not found". Unfortunately in this case, it is the fall-back chosen by Cygwin's `pinfo::status_exit()` method when encountering the NSTATUS `STATUS_STACK_OVERFLOW`, see https://github.com/cygwin/cygwin/blob/cygwin-3.6.1/winsup/cygwin/pinfo.cc#L171 I verified manually that the stack overflow always happens somewhere around tree depth 1403, therefore 1024 should be a safe bound in these instances. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 939bcb0 commit 2377274

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

environment.c

+12
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,21 @@ int max_allowed_tree_depth =
8282
* the stack overflow can occur.
8383
*/
8484
512;
85+
#else
86+
#if defined(GIT_WINDOWS_NATIVE) && defined(__clang__) && defined(__aarch64__)
87+
/*
88+
* Similar to Visual C, it seems that on Windows/ARM64 the clang-based
89+
* builds have a smaller stack space available. When running out of
90+
* that stack space, a `STATUS_STACK_OVERFLOW` is produced. When the
91+
* Git command was run from an MSYS2 Bash, this unfortunately results
92+
* in an exit code 127. Let's prevent that by lowering the maximal
93+
* tree depth; This value seems to be low enough.
94+
*/
95+
1280;
8596
#else
8697
2048;
8798
#endif
99+
#endif
88100

89101
#ifndef PROTECT_HFS_DEFAULT
90102
#define PROTECT_HFS_DEFAULT 0

0 commit comments

Comments
 (0)