shallow: handle missing shallow commits gracefully

dscho · dscho · commit 17e9e9ae0e42 · 2025-05-15T14:43:29.000+02:00
As pointed out by CodeQL, `lookup_commit()` can return NULL.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/shallow.c b/shallow.c
@@ -702,7 +702,8 @@ void assign_shallow_commits_to_refs(struct shallow_info *info,
 	for (i = 0; i < nr_shallow; i++) {
 		struct commit *c = lookup_commit(the_repository,
 						 &oid[shallow[i]]);
-		c->object.flags |= BOTTOM;
+		if (c)
+			c->object.flags |= BOTTOM;
 	}
 
 	for (i = 0; i < ref->nr; i++)

Original file line number	Diff line number	Diff line change
`@@ -702,7 +702,8 @@ void assign_shallow_commits_to_refs(struct shallow_info *info,`
`702`	`702`	`for (i = 0; i < nr_shallow; i++) {`
`703`	`703`	`struct commit *c = lookup_commit(the_repository,`
`704`	`704`	`&oid[shallow[i]]);`
`705`		`- c->object.flags \|= BOTTOM;`
	`705`	`+ if (c)`
	`706`	`+ c->object.flags \|= BOTTOM;`
`706`	`707`	`}`
`707`	`708`
`708`	`709`	`for (i = 0; i < ref->nr; i++)`