Git GUI: fix Repository>Explore Working Copy (#4357)

dscho · Git for Windows Build Agent · commit d6a1dc883f80 · 2023-03-21T21:39:46.000Z
This is a companion PR of prati0100/git-gui#95 Since Git v2.39.1, we are a bit more stringent in searching the PATH. In particular, we specifically require the `.exe` suffix. However, the `Repository>Explore Working Copy` command asks for `explorer.exe` to be found on the `PATH`, which _already_ has that suffix. Let's unstartle the PATH-finding logic about this scenario. This fixes #4356
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
@@ -108,6 +108,9 @@ proc _which {what args} {
 
 	if {[is_Windows] && [lsearch -exact $args -script] >= 0} {
 		set suffix {}
+	} elseif {[string match *$_search_exe $what]} {
+		# The search string already has the file extension
+		set suffix {}
 	} else {
 		set suffix $_search_exe
 	}

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,9 @@ proc _which {what args} {`
`108`	`108`
`109`	`109`	`if {[is_Windows] && [lsearch -exact $args -script] >= 0} {`
`110`	`110`	`set suffix {}`
	`111`	`+ } elseif {[string match *$_search_exe $what]} {`
	`112`	`+ # The search string already has the file extension`
	`113`	`+ set suffix {}`
`111`	`114`	`} else {`
`112`	`115`	`set suffix $_search_exe`
`113`	`116`	`}`