Fix global repository field not being cleared (#4083)

dscho · Git for Windows Build Agent · commit 2435f2286a80 · 2023-03-28T00:23:45.000Z
It is checked for w.r.t. global repository struct down in the callstack
in compatibility layer for MinGW before being assigned in the function
that `free()`'d it.
diff --git a/repository.c b/repository.c
@@ -48,7 +48,7 @@ static void repo_set_commondir(struct repository *repo,
 {
 	struct strbuf sb = STRBUF_INIT;
 
-	free(repo->commondir);
+	FREE_AND_NULL(repo->commondir);
 
 	if (commondir) {
 		repo->different_commondir = 1;

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ static void repo_set_commondir(struct repository *repo,`
`48`	`48`	`{`
`49`	`49`	`struct strbuf sb = STRBUF_INIT;`
`50`	`50`
`51`		`- free(repo->commondir);`
	`51`	`+ FREE_AND_NULL(repo->commondir);`
`52`	`52`
`53`	`53`	`if (commondir) {`
`54`	`54`	`repo->different_commondir = 1;`