Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of the property vat_percentage out of diapason #19

Open
BohdanLeasoft opened this issue Aug 16, 2022 · 0 comments
Open

Value of the property vat_percentage out of diapason #19

BohdanLeasoft opened this issue Aug 16, 2022 · 0 comments

Comments

@BohdanLeasoft
Copy link
Contributor

Hello,

I put 0 as value of vat_percentage. But I got exception: GingerPluginSdk\Exceptions\OutOfDiapasonException: Value of the property vat_percentage out of diapason, the input value is 0 : should be greater than 1, and less then 10000. in GingerPluginSdk\Properties\VatPercentage->validate() (line 40 of modules/contrib/custom_drupal_commerce/vendor/gingerpayments/ginger-plugin-sdk/src/Properties/VatPercentage.php).

As I know, the statement "should be greater than 1, and less then 10000." isn't correct. According this article about order line, vat_percentage should be >= 0 and <= 10000

Validation of vat_percentage occur in Properties\VatPercentage in method validate($value). Is it possible to change min value to 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant