Skip to content
This repository was archived by the owner on Jul 1, 2020. It is now read-only.

Commit c7114fc

Browse files
committed
merged PR #162 and PR #163
1 parent e369000 commit c7114fc

File tree

6 files changed

+12
-14
lines changed

6 files changed

+12
-14
lines changed

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-validation-ghiscoding",
3-
"version": "1.5.22",
3+
"version": "1.5.23",
44
"author": "Ghislain B.",
55
"description": "Angular-Validation Directive and Service (ghiscoding)",
66
"main": [

dist/angular-validation.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
* Angular-Validation Directive and Service (ghiscoding)
33
* http://github.com/ghiscoding/angular-validation
44
* @author: Ghislain B.
5-
* @version: 1.5.22
5+
* @version: 1.5.23
66
* @license: MIT
7-
* @build: Wed Jun 07 2017 22:01:12 GMT-0400 (Eastern Daylight Time)
7+
* @build: Thu Aug 17 2017 00:34:56 GMT-0400 (Eastern Daylight Time)
88
*/
99
/**
1010
* Angular-Validation Directive (ghiscoding)
@@ -617,7 +617,7 @@ angular
617617
self = analyzeElementAttributes(self);
618618

619619
// get the rules(or validation), inside directive it's named (validation), inside service(rules)
620-
var rules = self.validatorAttrs.rules || self.validatorAttrs.validation;
620+
var rules = self.validatorAttrs.rules || self.validatorAttrs.validation || '';
621621

622622
// We first need to see if the validation holds a custom user regex, if it does then deal with it first
623623
// So why deal with it separately? Because a Regex might hold pipe '|' and so we don't want to mix it with our regular validation pipe
@@ -1255,7 +1255,7 @@ angular
12551255
var formName = (!!formObj) ? formObj.getAttribute("name") : null;
12561256

12571257
if (!!formObj && !!formName) {
1258-
parentForm = (!!_globalOptions && !!_globalOptions.controllerAs && formName.indexOf('.') >= 0)
1258+
var parentForm = (!!_globalOptions && !!_globalOptions.controllerAs && formName.indexOf('.') >= 0)
12591259
? objectFindById(self.scope, formName, '.')
12601260
: self.scope[formName];
12611261

dist/angular-validation.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-validation-ghiscoding",
3-
"version": "1.5.22",
3+
"version": "1.5.23",
44
"author": "Ghislain B.",
55
"description": "Angular-Validation Directive and Service (ghiscoding)",
66
"main": "dist/angular-validation.min",

protractor/badInput_spec.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ describe('Angular-Validation badInput Tests:', function () {
4545
it('Should display same invalid character error message even after a Tab', function() {
4646
// make input3 invalid, remove text
4747
var elmInput2 = $('[name=input2]');
48-
element(by.css('body')).click();
4948
elmInput2.sendKeys(protractor.Key.TAB);
5049

5150
// error should appear on input2
@@ -82,7 +81,7 @@ describe('Angular-Validation badInput Tests:', function () {
8281
});
8382

8483
it('Should hide ValidationSummary after clicking on checkbox', function() {
85-
var btnShowSummary = $('[name=btn_showValidation]');
84+
var btnShowSummary = $('[name=chkbox_validationSummary]');
8685
btnShowSummary.click();
8786
browser.waitForAngular();
8887

@@ -96,7 +95,6 @@ describe('Angular-Validation badInput Tests:', function () {
9695
var elmInput2 = $('[name=input2]');
9796
elmInput2.click();
9897
clearInput(elmInput2, 5);
99-
element(by.css('body')).click();
10098
elmInput2.sendKeys(protractor.Key.TAB);
10199

102100
// error should appear on input2
@@ -105,7 +103,7 @@ describe('Angular-Validation badInput Tests:', function () {
105103
});
106104

107105
it('Should show ValidationSummary after clicking on show checkbox', function() {
108-
var btnShowSummary = $('[name=btn_showValidation]');
106+
var btnShowSummary = $('[name=chkbox_validationSummary]');
109107
btnShowSummary.click();
110108
browser.waitForAngular();
111109

readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Angular Validation (Directive / Service)
2-
`Version: 1.5.22`
2+
`Version: 1.5.23`
33
### Forms Validation with Angular made easy!
44
##### (Concept comes from the amazing Laravel)
55

0 commit comments

Comments
 (0)