From d6fa57dd0b2c614f024b25735314c4cfce2ec424 Mon Sep 17 00:00:00 2001 From: Son Pham-Ba Date: Thu, 9 Nov 2023 16:38:18 +0100 Subject: [PATCH] put kwargs in test functions calls Co-authored-by: Gionata Ghiggi --- gpm_api/tests/test_dataset/test_granule.py | 16 ++++++++-------- gpm_api/tests/test_io/test_find.py | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gpm_api/tests/test_dataset/test_granule.py b/gpm_api/tests/test_dataset/test_granule.py index 0842f63c..c171d686 100644 --- a/gpm_api/tests/test_dataset/test_granule.py +++ b/gpm_api/tests/test_dataset/test_granule.py @@ -314,19 +314,19 @@ def mock_set_coordinates(ds, *args, **kwargs): da = xr.DataArray(np.random.rand(1, 1, 1), dims=("lat", "lon", "other")) expected_dims = ("other", "lat", "lon") ds = xr.Dataset({"var": da, "time": time}) - ds = finalize_dataset(ds, product, False, scan_mode) + ds = finalize_dataset(ds, product=product, scan_mode=scan_mode, decode_cf=False) assert ds["var"].dims == expected_dims da = xr.DataArray(np.random.rand(1, 1, 1), dims=("other", "cross_track", "along_track")) expected_dims = ("cross_track", "along_track", "other") ds = xr.Dataset({"var": da, "time": time}) - ds = finalize_dataset(ds, product, False, scan_mode) + ds = finalize_dataset(ds, product=product, scan_mode=scan_mode, decode_cf=False) assert ds["var"].dims == expected_dims da = xr.DataArray(np.random.rand(1, 1), dims=("other", "along_track")) expected_dims = ("along_track", "other") ds = xr.Dataset({"var": da, "time": time}) - ds = finalize_dataset(ds, product, False, scan_mode) + ds = finalize_dataset(ds, product=product, scan_mode=scan_mode, decode_cf=False) assert ds["var"].dims == expected_dims # Check time subsetting @@ -340,7 +340,7 @@ def mock_subset_by_time(ds, start_time, end_time): ds = xr.Dataset({"var": da, "time": time}) start_time = datetime.fromtimestamp(np.random.randint(0, MAX_TIMESTAMP)) end_time = datetime.fromtimestamp(np.random.randint(0, MAX_TIMESTAMP)) - ds = finalize_dataset(ds, product, False, scan_mode, start_time=start_time, end_time=end_time) + ds = finalize_dataset(ds, product=product, scan_mode=scan_mode, decode_cf=False, start_time=start_time, end_time=end_time) assert ds.attrs["start_time"] == start_time assert ds.attrs["end_time"] == end_time @@ -354,7 +354,7 @@ def mock_decode_cf(ds, *args, **kwargs): monkeypatch.setattr(xr, "decode_cf", mock_decode_cf) ds = xr.Dataset({"var": da, "time": time}) - ds = finalize_dataset(ds, product, True, scan_mode) + ds = finalize_dataset(ds, product=product, scan_mode=scan_mode, decode_cf=True) assert ds.attrs["decoded"] # Check addition of attributes @@ -371,14 +371,14 @@ def mock_add_history(ds, *args, **kwargs): monkeypatch.setattr(conventions, "add_history", mock_add_history) ds = xr.Dataset({"var": da, "time": time}) - ds = finalize_dataset(ds, product, False, scan_mode) + ds = finalize_dataset(ds, product=product, scan_mode=scan_mode, decode_cf=False) assert ds.attrs["coords_attrs"] assert ds.attrs["history"] assert ds.attrs["gpm_api_product"] == product # Check time encoding ds = xr.Dataset({"var": da, "time": time}) - ds = finalize_dataset(ds, product, False, scan_mode) + ds = finalize_dataset(ds, product=product, scan_mode=scan_mode, decode_cf=False) expected_time_encoding = { "units": "seconds since 1970-01-01 00:00:00", "calendar": "proleptic_gregorian", @@ -393,5 +393,5 @@ def mock_set_dataset_crs(ds, *args, **kwargs): monkeypatch.setattr(conventions, "set_dataset_crs", mock_set_dataset_crs) ds = xr.Dataset({"var": da, "time": time}) - ds = finalize_dataset(ds, product, False, scan_mode) + ds = finalize_dataset(ds, product=product, scan_mode=scan_mode, decode_cf=False) assert ds.attrs["crs"] diff --git a/gpm_api/tests/test_io/test_find.py b/gpm_api/tests/test_io/test_find.py index 6f109259..405edb7a 100644 --- a/gpm_api/tests/test_io/test_find.py +++ b/gpm_api/tests/test_io/test_find.py @@ -95,7 +95,7 @@ def test_get_pps_daily_filepaths( ] def mock_get_pps_file_list(url_product_dir: str) -> List[str]: - # Remove the base URL, assuming they have the followgin format: + # Remove the base URL, assuming they have the following format: # RS: https://arthurhouhttps.pps.eosdis.nasa.gov/text/... # NRT: https://jsimpsonhttps.pps.eosdis.nasa.gov/text/... url_without_base = url_product_dir.split("/text")[1]