Skip to content

Commit e917f74

Browse files
committed
Address review
1 parent 645ecec commit e917f74

File tree

2 files changed

+4
-16
lines changed

2 files changed

+4
-16
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,8 @@ jobs:
127127
cargo clippy --target ${{ matrix.target }} -p wgpu --tests --features glsl,spirv
128128
cargo doc --target ${{ matrix.target }} -p wgpu --no-deps --features glsl,spirv
129129
130-
# build for WebGL
131-
cargo clippy --target ${{ matrix.target }} -p wgpu --tests --features webgl,glsl,spirv
132-
cargo doc --target ${{ matrix.target }} -p wgpu --no-deps --features webgl,glsl,spirv
133-
134130
# all features
135-
cargo clippy --target ${{ matrix.target }} -p wgpu-hal --tests --all-features
136-
cargo clippy --target ${{ matrix.target }} -p wgpu --tests --all-features
131+
cargo clippy --target ${{ matrix.target }} -p wgpu -p wgpu-hal --tests --all-features
137132
cargo doc --target ${{ matrix.target }} -p wgpu --no-deps --all-features
138133
139134
- name: check em
@@ -165,17 +160,10 @@ jobs:
165160
cargo clippy --target ${{ matrix.target }} -p wgpu -p wgpu-core -p wgpu-info -p player --no-default-features
166161
167162
# Check with all features.
168-
# (But watch out for backend-selection features in wgpu-core; some of
169-
# those only build on the right platforms.)
170-
cargo clippy --target ${{ matrix.target }} -p wgpu-hal --tests --all-features
171-
cargo clippy --target ${{ matrix.target }} -p wgpu-core --tests --all-features
172-
cargo clippy --target ${{ matrix.target }} -p wgpu -p wgpu-info -p player --tests --all-features
163+
cargo clippy --target ${{ matrix.target }} -p wgpu -p wgpu-info -p player -p wgpu-core -p wgpu-hal --tests --all-features
173164
174165
# build docs
175-
# (Watch out for backend-selection features in wgpu-core; some of
176-
# those only build on the right platforms.)
177-
cargo doc --target ${{ matrix.target }} -p wgpu -p wgpu-info -p player --all-features --no-deps
178-
cargo doc --target ${{ matrix.target }} -p wgpu-core --no-deps --all-features
166+
cargo doc --target ${{ matrix.target }} -p wgpu -p wgpu-info -p player -p wgpu-core -p wgpu-hal --all-features --no-deps
179167
180168
wasm-test:
181169
name: Test WebAssembly

wgpu-hal/src/dx12/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ and [`crate::CommandEncoder::set_render_pipeline`] with
2727
[`crate::CommandEncoder::set_compute_pipeline`].
2828
2929
For this reason, in order avoid repeating the binding code,
30-
we are binding everything in [`CommandEncoder::update_root_elements`].
30+
we are binding everything in `CommandEncoder::update_root_elements`.
3131
When the pipeline layout is changed, we reset all bindings.
3232
Otherwise, we pass a range corresponding only to the current bind group.
3333

0 commit comments

Comments
 (0)