Skip to content

Conversation

Copy link

Copilot AI commented Nov 27, 2025

Addresses feedback on PR #425 requesting test coverage for the static_liveness_resources filter property in ResourceContainer.

Changes

  • Added test_should_filter_static_liveness_resources test method mirroring the existing test_should_filter_zoom_liveness_resources pattern
  • Verifies the filter correctly returns only StaticLivenessResourceResponse instances from mixed liveness capture types
def test_should_filter_static_liveness_resources(self):
    data = {
        "liveness_capture": [
            {"liveness_type": "STATIC"},
            {"liveness_type": "someUnknown"},
        ]
    }
    result = ResourceContainer(data)
    assert len(result.liveness_capture) == 2
    assert len(result.static_liveness_resources) == 1

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add changes based on feedback for liveness check Add test coverage for static_liveness_resources filter property Nov 27, 2025
Copilot AI requested a review from mehmet-yoti November 27, 2025 12:02
Copilot finished work on behalf of mehmet-yoti November 27, 2025 12:02
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants