feat(eventuser): Drop eventuser-from-snuba feature flag (#61401)

## Objective:

This feature is GA'd. This is a cleanup PR to remove the feature flag.

Author: NisanthanNanthakumar

src/sentry/conf/server.py

@@ -1532,8 +1532,6 @@ def custom_parameter_sort(parameter: dict) -> tuple[str, int]:
     "organizations:escalating-metrics-backend": False,
     # Enable attaching arbitrary files to events.
     "organizations:event-attachments": True,
-    # Enable querying Snuba to get the EventUser
-    "organizations:eventuser-from-snuba": True,
     # Enable the frontend to request from region & control silo domains.
     "organizations:frontend-domainsplit": False,
     # Enable disabling gitlab integrations when broken is detected

src/sentry/features/__init__.py

@@ -255,7 +255,6 @@
 default_manager.add("organizations:escalating-issues-msteams", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:escalating-issues-v2", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
 default_manager.add("organizations:escalating-metrics-backend", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
-default_manager.add("organizations:eventuser-from-snuba", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
 default_manager.add("organizations:integrations-gh-invite", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:integrations-deployment", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
 default_manager.add("organizations:integrations-feature-flag-integration", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)

tests/acceptance/test_issue_tag_values.py

@@ -29,9 +29,8 @@ def create_issue(self):
         return self.store_event(data=event_data, project_id=self.project.id)
 
     def test_user_tag(self):
-        with self.feature("organizations:eventuser-from-snuba"):
-            self.page.visit_tag_values(self.org.slug, self.event.group_id, "user")
-            assert self.browser.element_exists_by_test_id("group-tag-mail")
+        self.page.visit_tag_values(self.org.slug, self.event.group_id, "user")
+        assert self.browser.element_exists_by_test_id("group-tag-mail")
 
     def test_url_tag(self):
         self.page.visit_tag_values(self.org.slug, self.event.group_id, "url")

tests/apidocs/endpoints/projects/test_users.py

@@ -55,7 +55,6 @@ def setUp(self):
         self.login_as(user=self.user)
 
     def test_get(self):
-        with self.feature("organizations:eventuser-from-snuba"):
-            response = self.client.get(self.url)
-            request = RequestFactory().get(self.url)
-            self.validate_schema(request, response)
+        response = self.client.get(self.url)
+        request = RequestFactory().get(self.url)
+        self.validate_schema(request, response)

tests/sentry/api/endpoints/test_group_tagkey_values.py

@@ -5,11 +5,9 @@
 
 from sentry.testutils.cases import APITestCase, PerformanceIssueTestCase, SnubaTestCase
 from sentry.testutils.helpers.datetime import before_now, iso_format
-from sentry.testutils.helpers.features import with_feature
 from sentry.testutils.silo import region_silo_test
 
 
-@with_feature("organizations:eventuser-from-snuba")
 @region_silo_test
 class GroupTagKeyValuesTest(APITestCase, SnubaTestCase, PerformanceIssueTestCase):
     @mock.patch("sentry.analytics.record")

tests/sentry/api/endpoints/test_project_users.py

@@ -1,5 +1,5 @@
 from datetime import timedelta
-from unittest import SkipTest, mock
+from unittest import mock
 
 from django.urls import reverse
 from django.utils import timezone
@@ -10,13 +10,8 @@
 from sentry.utils.eventuser import EventUser
 
 
-class ProjectUsersBaseTest(APITestCase):
-    @classmethod
-    def setUpClass(cls):
-        if cls is ProjectUsersBaseTest:
-            raise SkipTest("Skipping base class")
-        super().setUpClass()
-
+@region_silo_test
+class EventUserProjectUsersTest(APITestCase, SnubaTestCase):
     def setUp(self):
         super().setUp()
         self.project = self.create_project(date_added=(timezone.now() - timedelta(hours=2)))
@@ -27,9 +22,37 @@ def setUp(self):
                 "project_slug": self.project.slug,
             },
         )
-        # Make mypy happy
-        self.euser1 = EventUser(None, None, None, None, None, None)
-        self.euser2 = EventUser(None, None, None, None, None, None)
+
+        timestamp = iso_format(timezone.now() - timedelta(hours=1))
+
+        self.event1 = self.store_event(
+            project_id=self.project.id,
+            data={
+                "user": {
+                    "id": 1,
+                    "email": "[email protected]",
+                    "username": "foobar",
+                    "ip_address": "127.0.0.1",
+                },
+                "event_id": "b" * 32,
+                "timestamp": timestamp,
+            },
+        )
+        self.euser1 = EventUser.from_event(self.event1)
+        self.event2 = self.store_event(
+            project_id=self.project.id,
+            data={
+                "user": {
+                    "id": 2,
+                    "email": "[email protected]",
+                    "username": "baz",
+                    "ip_address": "192.168.0.1",
+                },
+                "event_id": "c" * 32,
+                "timestamp": timestamp,
+            },
+        )
+        self.euser2 = EventUser.from_event(self.event2)
 
     @mock.patch("sentry.analytics.record")
     def test_simple(self, mock_record):
@@ -121,44 +144,3 @@ def test_ip_search(self):
             assert response.data[0]["id"] is None
         else:
             assert response.data[0]["id"] == str(self.euser2.id)
-
-
-@region_silo_test
-class EventUserProjectUsersTest(ProjectUsersBaseTest, SnubaTestCase):
-    def setUp(self):
-        super().setUp()
-        timestamp = iso_format(timezone.now() - timedelta(hours=1))
-
-        self.event1 = self.store_event(
-            project_id=self.project.id,
-            data={
-                "user": {
-                    "id": 1,
-                    "email": "[email protected]",
-                    "username": "foobar",
-                    "ip_address": "127.0.0.1",
-                },
-                "event_id": "b" * 32,
-                "timestamp": timestamp,
-            },
-        )
-        self.euser1 = EventUser.from_event(self.event1)
-        self.event2 = self.store_event(
-            project_id=self.project.id,
-            data={
-                "user": {
-                    "id": 2,
-                    "email": "[email protected]",
-                    "username": "baz",
-                    "ip_address": "192.168.0.1",
-                },
-                "event_id": "c" * 32,
-                "timestamp": timestamp,
-            },
-        )
-        self.euser2 = EventUser.from_event(self.event2)
-        self.feature_manager = self.feature("organizations:eventuser-from-snuba")
-        self.feature_manager.__enter__()
-
-    def tearDown(self):
-        self.feature_manager.__exit__(None, None, None)

tests/sentry/api/serializers/test_organization.py

@@ -75,7 +75,6 @@ def test_simple(self):
             "discover-query",
             "derive-code-mappings",
             "event-attachments",
-            "eventuser-from-snuba",
             "integrations-alert-rule",
             "integrations-chat-unfurl",
             "integrations-deployment",

tests/sentry/data_export/processors/test_issues_by_tag.py

@@ -9,7 +9,6 @@
 from sentry.models.project import Project
 from sentry.testutils.cases import SnubaTestCase, TestCase
 from sentry.testutils.helpers.datetime import before_now, iso_format
-from sentry.testutils.helpers.features import with_feature
 from sentry.utils.eventuser import EventUser
 
 
@@ -74,7 +73,6 @@ def test_get_lookup_key(self):
         assert IssuesByTagProcessor.get_lookup_key("generic") == "generic"
         assert IssuesByTagProcessor.get_lookup_key("user") == "sentry:user"
 
-    @with_feature("organizations:eventuser-from-snuba")
     def test_get_eventuser_callback(self):
         user_callback = IssuesByTagProcessor.get_eventuser_callback(self.project.id)
         processor = IssuesByTagProcessor(
@@ -88,7 +86,6 @@ def test_get_eventuser_callback(self):
         user_callback([sample])
         assert sample._eventuser == self.euser
 
-    @with_feature("organizations:eventuser-from-snuba")
     def test_get_callbacks(self):
         generic_callbacks = IssuesByTagProcessor.get_callbacks("generic", self.project.id)
         assert isinstance(generic_callbacks, list)
@@ -97,7 +94,6 @@ def test_get_callbacks(self):
         assert isinstance(user_callbacks, list)
         assert len(user_callbacks) == 1
 
-    @with_feature("organizations:eventuser-from-snuba")
     def test_serialize_row(self):
         processor = IssuesByTagProcessor(
             project_id=self.project.id,

tests/sentry/search/test_utils.py

@@ -22,7 +22,6 @@
 from sentry.services.hybrid_cloud.user.service import user_service
 from sentry.testutils.cases import APITestCase, SnubaTestCase, TestCase
 from sentry.testutils.helpers.datetime import before_now, freeze_time, iso_format
-from sentry.testutils.helpers.features import with_feature
 from sentry.testutils.silo import control_silo_test, region_silo_test
 
 
@@ -450,7 +449,6 @@ def test_unknown_user_value(self):
         result = self.parse_query("user.xxxxxx:example")
         assert result["tags"]["sentry:user"] == "xxxxxx:example"
 
-    @with_feature("organizations:eventuser-from-snuba")
     def test_user_lookup_with_dot_query(self):
         self.project.date_added = timezone.now() - timedelta(minutes=10)
         self.project.save()
@@ -470,12 +468,10 @@ def test_user_lookup_with_dot_query(self):
         result = self.parse_query("user.username:foobar")
         assert result["tags"]["sentry:user"] == "id:1"
 
-    @with_feature("organizations:eventuser-from-snuba")
     def test_unknown_user_legacy_syntax(self):
         result = self.parse_query("user:email:[email protected]")
         assert result["tags"]["sentry:user"] == "email:[email protected]"
 
-    @with_feature("organizations:eventuser-from-snuba")
     def test_user_lookup_legacy_syntax(self):
         self.project.date_added = timezone.now() - timedelta(minutes=10)
         self.project.save()

tests/sentry/utils/test_eventuser.py

@@ -9,7 +9,6 @@
 
 from sentry.testutils.cases import APITestCase, SnubaTestCase
 from sentry.testutils.helpers.datetime import before_now, freeze_time, iso_format
-from sentry.testutils.helpers.features import with_feature
 from sentry.testutils.silo import region_silo_test
 from sentry.utils.eventuser import EventUser
 
@@ -440,7 +439,6 @@ def test_tag_value_primary_is_ip(self):
         assert euser[0].email is None
         assert euser[0].tag_value == "ip:8.8.8.1"
 
-    @with_feature("organizations:eventuser-from-snuba")
     def test_for_tags(self):
         assert EventUser.for_tags(self.project.id, ["id:myminion"]) == {
             "id:myminion": EventUser.from_event(self.event_3)