Skip to content

Commit cfeaa0f

Browse files
authored
chore(issue_platform): Release GAed profile issue types, and remove unused ones (#89435)
Confirmed with #profiling that these releases and deletions are correct.
1 parent bda0570 commit cfeaa0f

File tree

5 files changed

+167
-197
lines changed

5 files changed

+167
-197
lines changed

src/sentry/issues/grouptype.py

Lines changed: 3 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -461,6 +461,7 @@ class ProfileFileIOGroupType(GroupType):
461461
description = "File I/O on Main Thread"
462462
category = GroupCategory.PERFORMANCE.value
463463
default_priority = PriorityLevel.LOW
464+
released = True
464465

465466

466467
@dataclass(frozen=True)
@@ -470,6 +471,7 @@ class ProfileImageDecodeGroupType(GroupType):
470471
description = "Image Decoding on Main Thread"
471472
category = GroupCategory.PERFORMANCE.value
472473
default_priority = PriorityLevel.LOW
474+
released = True
473475

474476

475477
@dataclass(frozen=True)
@@ -479,25 +481,7 @@ class ProfileJSONDecodeType(GroupType):
479481
description = "JSON Decoding on Main Thread"
480482
category = GroupCategory.PERFORMANCE.value
481483
default_priority = PriorityLevel.LOW
482-
483-
484-
@dataclass(frozen=True)
485-
class ProfileCoreDataExperimentalType(GroupType):
486-
type_id = 2004
487-
slug = "profile_core_data_main_exp"
488-
description = "Core Data on Main Thread"
489-
category = GroupCategory.PERFORMANCE.value
490-
default_priority = PriorityLevel.LOW
491-
492-
493-
# 2005 was ProfileRegexExperimentalType
494-
@dataclass(frozen=True)
495-
class ProfileViewIsSlowExperimentalType(GroupType):
496-
type_id = 2006
497-
slug = "profile_view_is_slow_experimental"
498-
description = "View Render/Layout/Update is slow"
499-
category = GroupCategory.PERFORMANCE.value
500-
default_priority = PriorityLevel.LOW
484+
released = True
501485

502486

503487
@dataclass(frozen=True)
@@ -510,15 +494,6 @@ class ProfileRegexType(GroupType):
510494
default_priority = PriorityLevel.LOW
511495

512496

513-
@dataclass(frozen=True)
514-
class ProfileFrameDropExperimentalType(GroupType):
515-
type_id = 2008
516-
slug = "profile_frame_drop_experimental"
517-
description = "Frame Drop"
518-
category = GroupCategory.PERFORMANCE.value
519-
default_priority = PriorityLevel.LOW
520-
521-
522497
@dataclass(frozen=True)
523498
class ProfileFrameDropType(GroupType):
524499
type_id = 2009
@@ -530,17 +505,6 @@ class ProfileFrameDropType(GroupType):
530505
default_priority = PriorityLevel.LOW
531506

532507

533-
@dataclass(frozen=True)
534-
class ProfileFunctionRegressionExperimentalType(GroupType):
535-
type_id = 2010
536-
slug = "profile_function_regression_exp"
537-
description = "Function Duration Regression (Experimental)"
538-
category = GroupCategory.PERFORMANCE.value
539-
enable_auto_resolve = False
540-
default_priority = PriorityLevel.LOW
541-
notification_config = NotificationConfig(context=[NotificationContextField.APPROX_START_TIME])
542-
543-
544508
@dataclass(frozen=True)
545509
class ProfileFunctionRegressionType(GroupType):
546510
type_id = 2011

tests/sentry/issues/endpoints/test_organization_group_index.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
PerformanceNPlusOneGroupType,
1818
PerformanceRenderBlockingAssetSpanGroupType,
1919
PerformanceSlowDBQueryGroupType,
20-
ProfileFileIOGroupType,
2120
)
2221
from sentry.models.activity import Activity
2322
from sentry.models.apitoken import ApiToken
@@ -3195,11 +3194,10 @@ def test_snuba_perf_issue(self, mock_query: MagicMock) -> None:
31953194
self.login_as(user=self.user)
31963195
# give time for consumers to run and propogate changes to clickhouse
31973196
sleep(1)
3198-
with self.feature([ProfileFileIOGroupType.build_visible_feature_name()]):
3199-
response = self.get_success_response(
3200-
sort="new",
3201-
query="user.email:[email protected]",
3202-
)
3197+
response = self.get_success_response(
3198+
sort="new",
3199+
query="user.email:[email protected]",
3200+
)
32033201
assert len(response.data) == 2
32043202
assert {r["id"] for r in response.data} == {
32053203
str(perf_group_id),

tests/sentry/issues/test_grouptype.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
GroupCategory,
1010
GroupType,
1111
GroupTypeRegistry,
12+
MetricIssuePOC,
1213
NoiseConfig,
1314
PerformanceGroupTypeDefaults,
14-
ProfileJSONDecodeType,
1515
get_group_type_by_slug,
1616
get_group_types_by_category,
1717
)
@@ -160,7 +160,7 @@ class GroupRegistryTest(BaseGroupTypeTest):
160160
def test_get_visible(self) -> None:
161161
registry = GroupTypeRegistry()
162162
registry.add(UptimeDomainCheckFailure)
163-
registry.add(ProfileJSONDecodeType)
163+
registry.add(MetricIssuePOC)
164164
assert registry.get_visible(self.organization) == []
165165
with self.feature(UptimeDomainCheckFailure.build_visible_flagpole_feature_name()):
166166
assert registry.get_visible(self.organization) == [UptimeDomainCheckFailure]

tests/sentry/tasks/test_post_process.py

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
GroupCategory,
2828
PerformanceNPlusOneGroupType,
2929
PerformanceP95EndpointRegressionGroupType,
30-
ProfileFileIOGroupType,
3130
)
3231
from sentry.issues.ingest import save_issue_occurrence
3332
from sentry.models.activity import Activity, ActivityIntegration
@@ -2701,17 +2700,16 @@ def create_event(self, data, project_id, assert_no_errors=True):
27012700
def call_post_process_group(
27022701
self, is_new, is_regression, is_new_group_environment, event, cache_key=None
27032702
):
2704-
with self.feature(ProfileFileIOGroupType.build_post_process_group_feature_name()):
2705-
post_process_group(
2706-
is_new=is_new,
2707-
is_regression=is_regression,
2708-
is_new_group_environment=is_new_group_environment,
2709-
cache_key=None,
2710-
group_id=event.group_id,
2711-
occurrence_id=event.occurrence.id,
2712-
project_id=event.group.project_id,
2713-
eventstream_type=EventStreamEventType.Generic,
2714-
)
2703+
post_process_group(
2704+
is_new=is_new,
2705+
is_regression=is_regression,
2706+
is_new_group_environment=is_new_group_environment,
2707+
cache_key=None,
2708+
group_id=event.group_id,
2709+
occurrence_id=event.occurrence.id,
2710+
project_id=event.group.project_id,
2711+
eventstream_type=EventStreamEventType.Generic,
2712+
)
27152713
return cache_key
27162714

27172715
def test_issueless(self):

0 commit comments

Comments
 (0)