ref(avatar): Remove unused savedDataUrl prop (#93747)

This prop isn't being used for anything and only serves to confuse us

Author: evanpurkhiser

static/app/components/avatarChooser.tsx

@@ -49,7 +49,6 @@ interface AvatarChooserProps {
   disabled?: boolean;
   help?: React.ReactNode;
   onSave?: (model: Model) => void;
-  savedDataUrl?: string;
   title?: string;
   type?: AvatarChooserType;
   uploadDomain?: string;
@@ -59,7 +58,6 @@ function AvatarChooser(props: AvatarChooserProps) {
   const {
     endpoint,
     model: propsModel,
-    savedDataUrl,
     disabled,
     title,
     help,
@@ -204,7 +202,6 @@ function AvatarChooser(props: AvatarChooserProps) {
                 {...props}
                 type={type}
                 model={model}
-                savedDataUrl={savedDataUrl}
                 uploadDomain={uploadDomain ?? ''}
                 updateDataUrlState={({dataUrl: newDataUrl}) =>
                   setNewAvatar(newDataUrl ?? null)

static/app/components/avatarUploader.tsx

@@ -51,9 +51,8 @@ type Props = {
     | 'sentryAppColor'
     | 'sentryAppSimple'
     | 'docIntegration';
-  updateDataUrlState: (opts: {dataUrl?: string; savedDataUrl?: string | null}) => void;
+  updateDataUrlState: (opts: {dataUrl?: string}) => void;
   uploadDomain: string;
-  savedDataUrl?: string;
 };
 
 type State = {
@@ -97,9 +96,8 @@ class AvatarUploader extends Component<Props, State> {
 
     this.revokeObjectUrl();
 
-    const {updateDataUrlState} = this.props;
     const objectURL = window.URL.createObjectURL(file);
-    this.setState({file, objectURL}, () => updateDataUrlState({savedDataUrl: null}));
+    this.setState({file, objectURL});
   };
 
   revokeObjectUrl = () =>
@@ -353,12 +351,12 @@ class AvatarUploader extends Component<Props, State> {
   }
 
   get imageSrc() {
-    const {savedDataUrl, model, type, uploadDomain} = this.props;
+    const {model, type, uploadDomain} = this.props;
     const uuid = model.avatar?.avatarUuid;
     const photoUrl =
       uuid && `${uploadDomain}/${AVATAR_URL_MAP[type] || 'avatar'}/${uuid}/`;
 
-    return savedDataUrl || this.state.objectURL || photoUrl;
+    return this.state.objectURL || photoUrl;
   }
 
   uploadClick = (ev: React.MouseEvent<HTMLButtonElement | HTMLAnchorElement>) => {

static/app/views/settings/organizationDeveloperSettings/sentryApplicationDetails.tsx

@@ -403,7 +403,6 @@ export default function SentryApplicationDetails(props: Props) {
         help={AVATAR_STYLES[avatarStyle].help.concat(
           isInternal() ? '' : t(' Required for publishing.')
         )}
-        savedDataUrl={undefined}
         defaultChoice={{
           choiceText: isColor ? t('Default logo') : t('Default small icon'),
           preview: getAvatarPreview(isColor),