nit(aci): cast detection type config to AlertRuleDetectionType in NOA translation layer (#93835)

Author: iamrajjoshi

src/sentry/incidents/typings/metric_detector.py

@@ -120,7 +120,7 @@ def from_workflow_engine_models(
             name=detector.name,
             action_identifier_id=detector.id,
             threshold_type=threshold_type,
-            detection_type=detector.config.get("detection_type"),
+            detection_type=AlertRuleDetectionType(detector.config.get("detection_type")),
             comparison_delta=detector.config.get("comparison_delta"),
             sensitivity=sensitivity,
             resolve_threshold=resolve_threshold,

tests/sentry/notifications/notification_action/metric_alert_registry/test_discord_metric_alert_handler.py

@@ -1,7 +1,7 @@
 import uuid
 from unittest import mock
 
-from sentry.incidents.models.alert_rule import AlertRuleThresholdType
+from sentry.incidents.models.alert_rule import AlertRuleDetectionType, AlertRuleThresholdType
 from sentry.incidents.models.incident import IncidentStatus, TriggerStatus
 from sentry.incidents.typings.metric_detector import (
     AlertContext,
@@ -106,7 +106,7 @@ def test_invoke_legacy_registry(self, mock_send_alert):
             name=self.detector.name,
             action_identifier_id=self.detector.id,
             threshold_type=AlertRuleThresholdType.ABOVE,
-            detection_type=None,
+            detection_type=AlertRuleDetectionType.STATIC,
             comparison_delta=None,
             alert_threshold=self.evidence_data.conditions[0]["comparison"],
         )

tests/sentry/notifications/notification_action/metric_alert_registry/test_email_metric_alert_handler.py

@@ -1,7 +1,7 @@
 import uuid
 from unittest import mock
 
-from sentry.incidents.models.alert_rule import AlertRuleThresholdType
+from sentry.incidents.models.alert_rule import AlertRuleDetectionType, AlertRuleThresholdType
 from sentry.incidents.models.incident import IncidentStatus, TriggerStatus
 from sentry.incidents.typings.metric_detector import (
     AlertContext,
@@ -110,7 +110,7 @@ def test_invoke_legacy_registry(self, mock_send_alert):
             name=self.detector.name,
             action_identifier_id=self.detector.id,
             threshold_type=AlertRuleThresholdType.ABOVE,
-            detection_type=None,
+            detection_type=AlertRuleDetectionType.STATIC,
             comparison_delta=None,
             alert_threshold=self.evidence_data.conditions[0]["comparison"],
         )

tests/sentry/notifications/notification_action/metric_alert_registry/test_msteams_metric_alert_handler.py

@@ -1,7 +1,7 @@
 import uuid
 from unittest import mock
 
-from sentry.incidents.models.alert_rule import AlertRuleThresholdType
+from sentry.incidents.models.alert_rule import AlertRuleDetectionType, AlertRuleThresholdType
 from sentry.incidents.models.incident import IncidentStatus, TriggerStatus
 from sentry.incidents.typings.metric_detector import (
     AlertContext,
@@ -107,7 +107,7 @@ def test_invoke_legacy_registry(self, mock_send_alert):
             name=self.detector.name,
             action_identifier_id=self.detector.id,
             threshold_type=AlertRuleThresholdType.ABOVE,
-            detection_type=None,
+            detection_type=AlertRuleDetectionType.STATIC,
             comparison_delta=None,
             alert_threshold=self.evidence_data.conditions[0]["comparison"],
         )

tests/sentry/notifications/notification_action/metric_alert_registry/test_opsgenie_metric_alert_handler.py

@@ -1,7 +1,7 @@
 import uuid
 from unittest import mock
 
-from sentry.incidents.models.alert_rule import AlertRuleThresholdType
+from sentry.incidents.models.alert_rule import AlertRuleDetectionType, AlertRuleThresholdType
 from sentry.incidents.models.incident import IncidentStatus, TriggerStatus
 from sentry.incidents.typings.metric_detector import (
     AlertContext,
@@ -103,7 +103,7 @@ def test_invoke_legacy_registry(self, mock_send_alert):
             name=self.detector.name,
             action_identifier_id=self.detector.id,
             threshold_type=AlertRuleThresholdType.ABOVE,
-            detection_type=None,
+            detection_type=AlertRuleDetectionType.STATIC,
             comparison_delta=None,
             alert_threshold=self.evidence_data.conditions[0]["comparison"],
         )

tests/sentry/notifications/notification_action/metric_alert_registry/test_pagerduty_metric_alert_handler.py

@@ -1,7 +1,7 @@
 import uuid
 from unittest import mock
 
-from sentry.incidents.models.alert_rule import AlertRuleThresholdType
+from sentry.incidents.models.alert_rule import AlertRuleDetectionType, AlertRuleThresholdType
 from sentry.incidents.models.incident import IncidentStatus, TriggerStatus
 from sentry.incidents.typings.metric_detector import (
     AlertContext,
@@ -101,7 +101,7 @@ def test_invoke_legacy_registry(self, mock_send_alert):
             name=self.detector.name,
             action_identifier_id=self.detector.id,
             threshold_type=AlertRuleThresholdType.ABOVE,
-            detection_type=None,
+            detection_type=AlertRuleDetectionType.STATIC,
             comparison_delta=None,
             alert_threshold=self.evidence_data.conditions[0]["comparison"],
         )

tests/sentry/notifications/notification_action/metric_alert_registry/test_sentry_app_metric_alert_handler.py

@@ -1,7 +1,7 @@
 import uuid
 from unittest import mock
 
-from sentry.incidents.models.alert_rule import AlertRuleThresholdType
+from sentry.incidents.models.alert_rule import AlertRuleDetectionType, AlertRuleThresholdType
 from sentry.incidents.models.incident import IncidentStatus, TriggerStatus
 from sentry.incidents.typings.metric_detector import (
     AlertContext,
@@ -114,7 +114,7 @@ def test_invoke_legacy_registry(self, mock_send_alert):
             name=self.detector.name,
             action_identifier_id=self.detector.id,
             threshold_type=AlertRuleThresholdType.ABOVE,
-            detection_type=None,
+            detection_type=AlertRuleDetectionType.STATIC,
             comparison_delta=None,
             alert_threshold=self.evidence_data.conditions[0]["comparison"],
         )

tests/sentry/notifications/notification_action/metric_alert_registry/test_slack_metric_alert_handler.py

@@ -1,7 +1,7 @@
 import uuid
 from unittest import mock
 
-from sentry.incidents.models.alert_rule import AlertRuleThresholdType
+from sentry.incidents.models.alert_rule import AlertRuleDetectionType, AlertRuleThresholdType
 from sentry.incidents.models.incident import IncidentStatus, TriggerStatus
 from sentry.incidents.typings.metric_detector import (
     AlertContext,
@@ -109,7 +109,7 @@ def test_invoke_legacy_registry(self, mock_send_alert):
             name=self.detector.name,
             action_identifier_id=self.detector.id,
             threshold_type=AlertRuleThresholdType.ABOVE,
-            detection_type=None,
+            detection_type=AlertRuleDetectionType.STATIC,
             comparison_delta=None,
             alert_threshold=self.evidence_data.conditions[0]["comparison"],
         )

tests/sentry/notifications/notification_action/test_metric_alert_registry_handlers.py

@@ -62,7 +62,11 @@ def send_alert(
 class MetricAlertHandlerBase(BaseWorkflowTest):
     def create_models(self):
         self.project = self.create_project()
-        self.detector = self.create_detector(project=self.project)
+        self.detector = self.create_detector(
+            project=self.project,
+            config={"detection_type": "static", "threshold_period": 1},
+            type="metric_issue",
+        )
 
         with self.tasks():
             self.snuba_query = create_snuba_query(
@@ -406,7 +410,7 @@ def test_invoke_legacy_registry(self, mock_send_alert):
             name=self.detector.name,
             action_identifier_id=self.detector.id,
             threshold_type=AlertRuleThresholdType.ABOVE,
-            detection_type=None,
+            detection_type=AlertRuleDetectionType.STATIC,
             comparison_delta=None,
             sensitivity=None,
             resolve_threshold=None,