Skip to content

Commit 174035e

Browse files
Tweak Trigger: labels (#42452)
Two changes: 1. **Observe the `Foo: Bar` pattern.** Use the `aliases` feature to [rename](https://github.com/Financial-Times/github-label-sync#label-config-file). "For example, given the following config, GitHub Label Sync will look for labels on GitHub named either 'feature' or 'enhancement' then _update_ them to match the newer config rather than deleting them." 2. **Standardize [**colors**](https://storybook.sentry.dev/?path=/story/core-colors--page).** I recently [introduced](#42447) a `Sync: Jira` label, which seems loosely related to `Trigger: `. I propose using the same color for both types. --------- Co-authored-by: Evan Purkhiser <[email protected]>
1 parent 6e7b79c commit 174035e

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/labels.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@
88
# Read more here: https://github.com/Financial-Times/github-label-sync#label-config-file
99

1010
# Getsentry workflow control
11-
- name: trigger-getsentry-external
12-
color: '3E5E06'
11+
- name: 'Trigger: getsentry tests'
12+
aliases: ['trigger-getsentry-external']
13+
color: 'A0CABD'
1314
description: 'once code is reviewed: apply label to PR to trigger getsentry tests'
1415
- name: 'Trigger: Revert'
15-
color: '3E5E06'
16+
color: 'A0CABD'
1617
description: 'add to a merged PR to revert it (skips CI)'
1718
- name: 'Trigger: Visual Snapshot'
1819
color: '3E5E06'

.github/workflows/getsentry-dispatch.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ permissions:
1919

2020
jobs:
2121
dispatch:
22-
if: github.event.action != 'labeled' || github.event.label.name == 'trigger-getsentry-external'
22+
if: "github.event.action != 'labeled' || github.event.label.name == 'Trigger: getsentry tests'"
2323
name: getsentry dispatch
2424
runs-on: ubuntu-20.04
2525
steps:

.github/workflows/scripts/getsentry-dispatch-setup

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import json
44
import os
55
import urllib.request
66

7-
LABEL = "trigger-getsentry-external"
7+
LABEL = "Trigger: getsentry tests"
88

99

1010
def _has_write(repo_id: int, username: str, *, token: str) -> bool:

0 commit comments

Comments
 (0)