Merge branch 'master' into cwlw/tweak-trigger-labels

Author: chadwhitacre

.eslintignore

@@ -1,9 +1,7 @@
 **/dist/**/*
 **/vendor/**/*
-**/tests/**/lang/javascript/fixtures/**/*
-**/tests/**/lang/javascript/example-project/**/*
+**/tests/**/fixtures/**/*
 /scripts/
 !.github
 !.github/workflows/scripts/*
-!.storybook
 *.d.ts

.gitattributes

@@ -0,0 +1,2 @@
+model-manifest.json binary
+tests/js/test-balancer/jest-balance.json binary

.github/CODEOWNERS

@@ -11,18 +11,16 @@
 /src/sentry/migrations/                                  @getsentry/owners-migrations
 /src/sentry/*/migrations/                                @getsentry/owners-migrations
 
-## API Owners for unowned endpoints / serializers
-/src/**/endpoints/                                       @getsentry/owners-api
-/src/sentry/api/                                         @getsentry/owners-api
-
 ## Snuba
 /src/sentry/eventstream/                                 @getsentry/owners-snuba
-/src/sentry/utils/snuba.py                               @getsentry/owners-snuba @getsentry/visibility
+/src/sentry/utils/snuba.py                               @getsentry/owners-snuba @getsentry/discover-n-dashboards
 /src/sentry/utils/snql.py                                @getsentry/owners-snuba
 /src/sentry/tsdb/snuba.py                                @getsentry/owners-snuba
 /src/sentry/tsdb/redissnuba.py                           @getsentry/owners-snuba
 /src/sentry/search/snuba/                                @getsentry/owners-snuba
 /src/sentry/tagstore/snuba/                              @getsentry/owners-snuba
+/src/sentry/sentry_metrics/                              @getsentry/owners-snuba
+/tests/sentry/sentry_metrics/
 
 ## Event Ingestion
 /src/sentry/attachments/                                 @getsentry/owners-ingest
@@ -39,11 +37,13 @@
 /src/sentry/scripts/quotas/                              @getsentry/owners-ingest
 /src/sentry/scripts/tsdb/                                @getsentry/owners-ingest
 /src/sentry/tasks/store.py                               @getsentry/owners-ingest
+/src/sentry/tasks/relay.py                               @getsentry/owners-ingest
 /src/sentry/tasks/unmerge.py                             @getsentry/owners-ingest
 /tests/sentry/event_manager/                             @getsentry/owners-ingest
 /tests/sentry/ingest/                                    @getsentry/owners-ingest
 /tests/sentry/relay/                                     @getsentry/owners-ingest
 /tests/relay_integration/                                @getsentry/owners-ingest
+/bin/invalidate-project-configs                          @getsentry/owners-ingest
 
 ## Security
 /src/sentry/net/                                         @getsentry/security
@@ -86,12 +86,19 @@ yarn.lock                                                @getsentry/owners-js-de
 /static/app/icons/                                       @getsentry/design
 /static/fonts/                                           @getsentry/design
 /static/images/                                          @getsentry/design
-/docs-ui/components/                                     @getsentry/design @getsentry/core-ui
 
 ## Core UI
-/static/app/components                                   @getsentry/core-ui
-/static/app/views/issueList                              @getsentry/core-ui
-/static/app/views/organizationGroupDetails               @getsentry/core-ui
+/static/app/components                                       @getsentry/core-ui
+
+/static/app/views/issueList                                  @getsentry/core-ui
+/static/app/views/organizationGroupDetails                   @getsentry/core-ui
+
+## Crons
+/static/app/views/monitors                                   @getsentry/crons
+/src/sentry/monitors                                         @getsentry/crons
+/tests/sentry/monitors                                       @getsentry/crons
+/src/sentry/utils/monitors.py                                @getsentry/crons
+/tests/sentry/utils/test_monitors.py                         @getsentry/crons
 
 
 # Owners by product feature
@@ -138,18 +145,29 @@ yarn.lock                                                @getsentry/owners-js-de
 
 
 ## Visibility
-/src/sentry/api/endpoints/organization_tags.py               @getsentry/visibility
-/src/sentry/api/endpoints/organization_events_histogram.py   @getsentry/visibility
-/tests/snuba/api/endpoints/                                  @getsentry/visibility
-/src/sentry/api/serializers/snuba.py                         @getsentry/visibility
-/src/sentry/snuba/discover.py                                @getsentry/visibility
-/src/sentry/snuba/metrics_performance.py                     @getsentry/visibility
-/src/sentry/snuba/metrics_enhanced_performance.py            @getsentry/visibility
-
-/src/sentry/search/events/                                   @getsentry/visibility
-/tests/snuba/search/test_backend.py                          @getsentry/visibility
-/static/app/utils/discover/                                  @getsentry/visibility
-/static/app/components/charts/                               @getsentry/visibility
+/src/sentry/api/endpoints/organization_tags.py                              @getsentry/performance
+/src/sentry/api/endpoints/organization_events_histogram.py                  @getsentry/performance
+
+/tests/snuba/api/endpoints/*                                                @getsentry/discover-n-dashboards
+/tests/snuba/api/endpoints/test_organization_events_histogram.py            @getsentry/performance
+/tests/snuba/api/endpoints/test_organization_events_facets_performance.py   @getsentry/performance
+/tests/snuba/api/endpoints/test_organization_events_spans_performance.py    @getsentry/performance
+/tests/snuba/api/endpoints/test_organization_events_spans_histogram.py      @getsentry/performance
+/tests/snuba/api/endpoints/test_organization_events_trace.py                @getsentry/performance
+/tests/snuba/api/endpoints/test_organization_events_trends.py               @getsentry/performance
+/tests/snuba/api/endpoints/test_organization_events_vitals.py               @getsentry/performance
+/tests/snuba/api/endpoints/test_organization_tagkey_values.py               @getsentry/performance
+/tests/snuba/api/endpoints/test_organization_tags.py                        @getsentry/performance
+
+/src/sentry/api/serializers/snuba.py                                        @getsentry/discover-n-dashboards
+/src/sentry/snuba/discover.py                                               @getsentry/discover-n-dashboards
+/src/sentry/snuba/metrics_performance.py                                    @getsentry/discover-n-dashboards
+/src/sentry/snuba/metrics_enhanced_performance.py                           @getsentry/discover-n-dashboards
+
+/src/sentry/search/events/                                                  @getsentry/discover-n-dashboards
+/tests/snuba/search/test_backend.py                                         @getsentry/discover-n-dashboards
+/static/app/utils/discover/                                                 @getsentry/discover-n-dashboards
+/static/app/components/charts/                                              @getsentry/discover-n-dashboards
 ## Endof Visibility
 
 
@@ -219,11 +237,11 @@ yarn.lock                                                @getsentry/owners-js-de
 
 
 ## Replays
-/static/app/components/replays/   @getsentry/emerging-technology
-/static/app/utils/replays/        @getsentry/emerging-technology
-/static/app/views/replays/        @getsentry/emerging-technology
-/src/sentry/replays/              @getsentry/emerging-technology
-/tests/sentry/replays/            @getsentry/emerging-technology
+/static/app/components/replays/   @getsentry/replay-frontend
+/static/app/utils/replays/        @getsentry/replay-frontend
+/static/app/views/replays/        @getsentry/replay-frontend
+/src/sentry/replays/              @getsentry/replay-backend
+/tests/sentry/replays/            @getsentry/replay-backend
 ## End of Replays
 
 
@@ -235,10 +253,10 @@ yarn.lock                                                @getsentry/owners-js-de
 /src/sentry/api/endpoints/sentry_app/                                @getsentry/ecosystem
 
 /static/app/views/organizationIntegrations                           @getsentry/ecosystem
+/static/app/views/settings/project/projectOwnership/                 @getsentry/ecosystem
 
 /src/sentry/digests/                                                 @getsentry/ecosystem
 /src/sentry/identity/                                                @getsentry/ecosystem
-/src/sentry/identity/                                                @getsentry/ecosystem
 /src/sentry/integrations/                                            @getsentry/ecosystem
 /src/sentry/mail/                                                    @getsentry/ecosystem
 /src/sentry/mediators/                                               @getsentry/ecosystem
@@ -274,9 +292,6 @@ yarn.lock                                                @getsentry/owners-js-de
 *doc_integration*.py                                                 @getsentry/ecosystem
 *docintegration*.py                                                  @getsentry/ecosystem
 
-/api-docs/                                                           @getsentry/ecosystem
-/tests/apidocs/                                                      @getsentry/ecosystem
-
 /src/sentry/middleware/ratelimit.py                                  @getsentry/ecosystem
 /src/sentry/middleware/access_log.py                                 @getsentry/ecosystem
 ## End of Ecosystem
@@ -355,6 +370,7 @@ yarn.lock                                                @getsentry/owners-js-de
 /src/sentry/api/endpoints/organization_sessions.py                               @getsentry/telemetry-experience
 /src/sentry/api/endpoints/project_dynamic_sampling.py                            @getsentry/telemetry-experience
 /src/sentry/api/endpoints/organization_dynamic_sampling_sdk_versions.py          @getsentry/telemetry-experience
+/src/sentry/dynamic_sampling/                                                    @getsentry/telemetry-experience
 /src/sentry/snuba/metrics/query.py                                               @getsentry/telemetry-experience
 /src/sentry/release_health/metrics_sessions_v2.py                                @getsentry/telemetry-experience
 /tests/sentry/api/endpoints/test_organization_metric_data.py                     @getsentry/telemetry-experience
@@ -400,3 +416,9 @@ yarn.lock                                                @getsentry/owners-js-de
 /tests/sentry/tasks/test_post_process.py            @getsentry/issue-platform
 /tests/snuba/search/                                @getsentry/issue-platform
 ## End of Issue Platform
+
+
+## Hybrid Cloud
+/src/sentry/silo/                     @getsentry/hybrid-cloud
+/src/sentry/services/hybrid_cloud/    @getsentry/hybrid-cloud
+## End of Hybrid Cloud

.github/actions/setup-sentry/action.yml

@@ -54,19 +54,16 @@ runs:
   using: 'composite'
   steps:
     - name: Setup default environment variables
-      shell: bash
+      # the default for "bash" is:
+      #      bash --noprofile --norc -eo pipefail {0}
+      shell: bash --noprofile --norc -eo pipefail -ux {0}
       env:
         MATRIX_INSTANCE: ${{ matrix.instance }}
         # XXX: We should be using something like len(strategy.matrix.instance) (not possible atm)
         # If you have other things like python-version: [foo, bar, baz] then the sharding logic
         # isn't right because job-total will be 3x larger and you'd never run 2/3 of the tests.
         # MATRIX_INSTANCE_TOTAL: ${{ strategy.job-total }}
       run: |
-        # Only set `MIGRATIONS_TEST_MIGRATE` if it is not already set (or if it's an empty string)
-        if [ -z $MIGRATIONS_TEST_MIGRATE ]; then
-          echo "MIGRATIONS_TEST_MIGRATE=0" >> $GITHUB_ENV
-        fi
-
         echo "PIP_DISABLE_PIP_VERSION_CHECK=on" >> $GITHUB_ENV
         echo "PIP_INDEX_URL=https://pypi.devinfra.sentry.io/simple" >> $GITHUB_ENV
         echo "SENTRY_SKIP_BACKEND_VALIDATION=1" >> $GITHUB_ENV
@@ -77,7 +74,7 @@ runs:
 
         ### pytest configuration ###
         echo "PY_COLORS=1" >> "$GITHUB_ENV"
-        echo "PYTEST_ADDOPTS=--reruns=5 --durations=10" >> $GITHUB_ENV
+        echo "PYTEST_ADDOPTS=--reruns=5 --durations=10 --fail-slow=60s" >> $GITHUB_ENV
 
         ### pytest-sentry configuration ###
         if [ "$GITHUB_REPOSITORY" = "getsentry/sentry" ]; then
@@ -100,46 +97,44 @@ runs:
 
         # this handles pytest test sharding
         if [ "$MATRIX_INSTANCE" ]; then
-          if ! [ "$MATRIX_INSTANCE_TOTAL" ]; then
+          if ! [ "${MATRIX_INSTANCE_TOTAL:-}" ]; then
             echo "MATRIX_INSTANCE_TOTAL is required."
             exit 1
           fi
           echo "TEST_GROUP=$MATRIX_INSTANCE" >> $GITHUB_ENV
           echo "TOTAL_TEST_GROUPS=$MATRIX_INSTANCE_TOTAL" >> $GITHUB_ENV
         fi
 
-    - name: Setup python
-      uses: actions/setup-python@13ae5bb136fac2878aff31522b9efb785519f984  # v4.3.0
+    - uses: getsentry/action-setup-venv@9e3bbae3836b1b6f129955bf55a19e1d99a61c67 # v1.0.5
       with:
         python-version: ${{ inputs.python-version }}
-        cache: pip
         cache-dependency-path: ${{ inputs.workdir }}/requirements-dev-frozen.txt
+        install-cmd: pip install -r ${{ inputs.workdir }}/requirements-dev-frozen.txt
 
     - name: Set up outputs
       id: config
       env:
         MATRIX_INSTANCE: ${{ matrix.instance }}
-      shell: bash
+      shell: bash --noprofile --norc -eo pipefail -ux {0}
       run: |
         echo "yarn-cache-dir=$(yarn cache dir)" >> "$GITHUB_OUTPUT"
         echo "matrix-instance-number=$(($MATRIX_INSTANCE+1))" >> "$GITHUB_OUTPUT"
-        echo "matrix-instance-total=$(($MATRIX_INSTANCE_TOTAL))" >> "$GITHUB_OUTPUT"
+        echo "matrix-instance-total=$((${MATRIX_INSTANCE_TOTAL:-}))" >> "$GITHUB_OUTPUT"
         echo "acceptance-dir=.artifacts/visual-snapshots/acceptance" >> "$GITHUB_OUTPUT"
 
     - name: Install python dependencies
-      shell: bash
+      shell: bash --noprofile --norc -eo pipefail -ux {0}
       env:
         # This is necessary when other repositories (e.g. relay) want to take advantage of this workflow
         # without needing to fork it. The path needed is the one where setup.py is located
         WORKDIR: ${{ inputs.workdir }}
       run: |
         cd "$WORKDIR"
-        pip install -r requirements-dev-frozen.txt
         # We need to install editable otherwise things like check migration will fail.
         SENTRY_LIGHT_BUILD=1 pip install --no-deps -e .
 
     - name: Start devservices
-      shell: bash
+      shell: bash --noprofile --norc -eo pipefail -ux {0}
       env:
         NEED_KAFKA: ${{ inputs.kafka }}
         NEED_SNUBA: ${{ inputs.snuba }}

.github/codeql/codeql-config.yml

@@ -1,4 +1,4 @@
-name: "Sentry CodeQL Config"
+name: 'Sentry CodeQL Config'
 
 paths-ignore:
   - '**/tests/**'

.github/dependabot.yml

@@ -34,20 +34,6 @@ updates:
       - dependency-name: '@babel/preset-typescript'
       - dependency-name: '@babel/runtime'
 
-      # Storybook updates should all happen in unison, same as above we ignore
-      # all but one as a reminder.
-      #
-      # - dependency-name: "@storybook/react"
-      - dependency-name: '@storybook/addon-a11y'
-      - dependency-name: '@storybook/addon-actions'
-      - dependency-name: '@storybook/addon-essentials'
-      - dependency-name: '@storybook/addon-storysource'
-      - dependency-name: '@storybook/addon-docs'
-      - dependency-name: '@storybook/addons'
-      - dependency-name: '@storybook/builder-webpack5'
-      - dependency-name: '@storybook/manager-webpack5'
-      - dependency-name: '@storybook/theming'
-
       # Sentry updates should all happen in unison, same as above we ignore
       # all but one as a reminder.
       # - dependency-name: "@sentry/react"
@@ -74,19 +60,12 @@ updates:
       - dependency-name: 'reflux'
       - dependency-name: 'sprintf-js'
       - dependency-name: 'u2f-api'
-
-  - package-ecosystem: pip
-    open-pull-requests-limit: 10
-    directory: '/'
+  - package-ecosystem: 'docker'
+    directory: 'docker/'
     schedule:
-      # Going to start with a high interval, and then tone it back
-      interval: daily
-      timezone: America/Los_Angeles
-      time: '09:00'
+      interval: 'daily'
     reviewers:
-      - '@getsentry/team-web-backend'
-    labels:
-      - 'dependencies'
-      - 'Scope: Backend'
-    allow:
-      - dependency-name: 'sentry-sdk'
+      - '@getsentry/open-source'
+      - '@getsentry/security'
+    # security only updates
+    open-pull-requests-limit: 0

.github/file-filters.yml

@@ -26,7 +26,6 @@ frontend_src: &frontend_src
   - '**/tsconfig*.json'
   - '{package,now,vercel}.json'
   - '**/*.less'
-  - 'docs-ui/**'
   - 'static/**'
   - 'fixtures/search-syntax/**/*'
   - '.github/workflows/frontend.yml'
@@ -75,8 +74,8 @@ backend_all: &backend_all
 
 # This is the ultimate controller for acceptance.yml
 acceptance: &acceptance
-  - *backend_all
   - *frontend_all
+  - *backend_all
   # This is verbose because backend_build_changes includes it, however,
   - '.github/actions/setup-sentry/action.yml'
   - '.github/workflows/acceptance.yml'