Fix warnings caused by deprecated Cocoa SDK API usages (#868)

* Remove deprecated sentry-cocoa API usages

* Update changelog

Author: tustanivsky

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixes
+
+- Fix warnings caused by deprecated Cocoa SDK API usages ([#868](https://github.com/getsentry/sentry-unreal/pull/868))
+
 ### Dependencies
 
 - Bump Java SDK (Android) from v8.6.0 to v8.7.0 ([#863](https://github.com/getsentry/sentry-unreal/pull/863))

plugin-dev/Source/Sentry/Private/Apple/AppleSentrySubsystem.cpp

@@ -243,7 +243,7 @@ void FAppleSentrySubsystem::CaptureUserFeedback(TSharedPtr<ISentryUserFeedback>
 {
 	TSharedPtr<SentryUserFeedbackApple> userFeedbackIOS = StaticCastSharedPtr<SentryUserFeedbackApple>(userFeedback);
 
-	[SENTRY_APPLE_CLASS(SentrySDK) captureUserFeedback:userFeedbackIOS->GetNativeObject()];
+	[SENTRY_APPLE_CLASS(SentrySDK) captureFeedback:userFeedbackIOS->GetNativeObject()];
 }
 
 void FAppleSentrySubsystem::SetUser(TSharedPtr<ISentryUser> user)
@@ -363,7 +363,9 @@ TSharedPtr<ISentryTransactionContext> FAppleSentrySubsystem::ContinueTrace(const
 		traceId:traceId
 		spanId:[[SENTRY_APPLE_CLASS(SentrySpanId) alloc] init]
 		parentSpanId:[[SENTRY_APPLE_CLASS(SentrySpanId) alloc] initWithValue:traceParts[1].GetNSString()]
-		parentSampled:sampleDecision];
+		parentSampled:sampleDecision
+		parentSampleRate:nil
+		parentSampleRand:nil];
 
 	// currently `sentry-cocoa` doesn't have API for `SentryTransactionContext` to set `baggageHeaders`
 

plugin-dev/Source/Sentry/Private/Apple/SentryUserFeedbackApple.cpp

@@ -11,15 +11,23 @@ SentryUserFeedbackApple::SentryUserFeedbackApple(TSharedPtr<ISentryId> eventId)
 {
 	TSharedPtr<SentryIdApple> idIOS = StaticCastSharedPtr<SentryIdApple>(eventId);
 	SentryId* id = idIOS->GetNativeObject();
-	UserFeedbackApple = [[SENTRY_APPLE_CLASS(SentryUserFeedback) alloc] initWithEventId:id];
+
+	// `SentryFeedback` is defined in Swift so its name that can be recognized by UE should be taken from "Sentry-Swift.h" to successfully load class on Mac
+#if PLATFORM_MAC
+	UserFeedbackApple = [[SENTRY_APPLE_CLASS(_TtC6Sentry14SentryFeedback) alloc] initWithMessage:@""
+		name:nil email:nil source:SentryFeedbackSourceCustom associatedEventId:id attachments:nil];
+#elif PLATFORM_IOS
+	UserFeedbackApple = [[SENTRY_APPLE_CLASS(SentryFeedback) alloc] initWithMessage:@""
+		name:nil email:nil source:SentryFeedbackSourceCustom associatedEventId:id attachments:nil];
+#endif
 }
 
 SentryUserFeedbackApple::~SentryUserFeedbackApple()
 {
 	// Put custom destructor logic here if needed
 }
 
-SentryUserFeedback* SentryUserFeedbackApple::GetNativeObject()
+SentryFeedback* SentryUserFeedbackApple::GetNativeObject()
 {
 	return UserFeedbackApple;
 }
@@ -46,10 +54,10 @@ FString SentryUserFeedbackApple::GetEmail() const
 
 void SentryUserFeedbackApple::SetComment(const FString& comment)
 {
-	UserFeedbackApple.comments = comment.GetNSString();
+	UserFeedbackApple.message = comment.GetNSString();
 }
 
 FString SentryUserFeedbackApple::GetComment() const
 {
-	return FString(UserFeedbackApple.comments);
+	return FString(UserFeedbackApple.message);
 }

plugin-dev/Source/Sentry/Private/Apple/SentryUserFeedbackApple.h

@@ -6,15 +6,15 @@
 
 class ISentryId;
 
-@class SentryUserFeedback;
+@class SentryFeedback;
 
 class SentryUserFeedbackApple : public ISentryUserFeedback
 {
 public:
 	SentryUserFeedbackApple(TSharedPtr<ISentryId> eventId);
 	virtual ~SentryUserFeedbackApple() override;
 
-	SentryUserFeedback* GetNativeObject();
+	SentryFeedback* GetNativeObject();
 
 	virtual void SetName(const FString& name) override;
 	virtual FString GetName() const override;
@@ -24,5 +24,5 @@ class SentryUserFeedbackApple : public ISentryUserFeedback
 	virtual FString GetComment() const override;
 
 private:
-	SentryUserFeedback* UserFeedbackApple;
+	SentryFeedback* UserFeedbackApple;
 };