Address CR comments

Jean85 · Jean85 · commit 2c77b9b04c2c · 2021-05-14T16:44:40.000+02:00
diff --git a/tests/End2End/App/Controller/MessengerController.php b/tests/End2End/App/Controller/MessengerController.php
@@ -37,7 +37,7 @@ public function dispatchUnrecoverableMessage(): Response
 
     public function dispatchUnrecoverableSyncMessage(): Response
     {
-        $this->messenger->dispatch(new SyncMessage(false));
+        $this->messenger->dispatch(new SyncMessage());
 
         return new Response('Success');
     }
diff --git a/tests/End2End/App/Messenger/IgnorableException.php b/tests/End2End/App/Messenger/IgnorableException.php
@@ -4,6 +4,6 @@
 
 namespace Sentry\SentryBundle\Tests\End2End\App\Messenger;
 
-class IgnorableException extends \Exception
+final class IgnorableException extends \Exception
 {
 }
diff --git a/tests/End2End/App/Messenger/SyncMessage.php b/tests/End2End/App/Messenger/SyncMessage.php
@@ -4,6 +4,6 @@
 
 namespace Sentry\SentryBundle\Tests\End2End\App\Messenger;
 
-class SyncMessage
+final class SyncMessage
 {
 }
diff --git a/tests/End2End/App/Messenger/SyncMessageHandler.php b/tests/End2End/App/Messenger/SyncMessageHandler.php
@@ -6,7 +6,7 @@
 
 use Symfony\Component\Messenger\Handler\MessageHandlerInterface;
 
-class SyncMessageHandler implements MessageHandlerInterface
+final class SyncMessageHandler implements MessageHandlerInterface
 {
     public function __invoke(SyncMessage $message): void
     {

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function dispatchUnrecoverableMessage(): Response`
`37`	`37`
`38`	`38`	`public function dispatchUnrecoverableSyncMessage(): Response`
`39`	`39`	`{`
`40`		`- $this->messenger->dispatch(new SyncMessage(false));`
	`40`	`+ $this->messenger->dispatch(new SyncMessage());`
`41`	`41`
`42`	`42`	`return new Response('Success');`
`43`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`
`5`	`5`	`namespace Sentry\SentryBundle\Tests\End2End\App\Messenger;`
`6`	`6`
`7`		`-class IgnorableException extends \Exception`
	`7`	`+final class IgnorableException extends \Exception`
`8`	`8`	`{`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`
`5`	`5`	`namespace Sentry\SentryBundle\Tests\End2End\App\Messenger;`
`6`	`6`
`7`		`-class SyncMessage`
	`7`	`+final class SyncMessage`
`8`	`8`	`{`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`use Symfony\Component\Messenger\Handler\MessageHandlerInterface;`
`8`	`8`
`9`		`-class SyncMessageHandler implements MessageHandlerInterface`
	`9`	`+final class SyncMessageHandler implements MessageHandlerInterface`
`10`	`10`	`{`
`11`	`11`	`public function __invoke(SyncMessage $message): void`
`12`	`12`	`{`