Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate release health behind a feature flag #748

Open
lcian opened this issue Mar 10, 2025 · 1 comment · May be fixed by #749
Open

Gate release health behind a feature flag #748

lcian opened this issue Mar 10, 2025 · 1 comment · May be fixed by #749
Assignees
Labels
area: core Core features of the SDK

Comments

@lcian
Copy link
Member

lcian commented Mar 10, 2025

Some targets (e.g. wasm32-wasip1) don't support threads.
By default, the SDK is compiled with session release health features: sentry-core/src/sessions.rs.
We should create a feature flag that enables/disables these features so that the SDK can be compiled for those targets by disabling the flag (similar to how a user can opt to create a custom transport and use none of the existing ones).
The feature should be enabled by default to respect existing behavior.

Features implemented in sentry-core/src/sessions.rs are exposed in the start_session function in sentry-core/src/hub.rs and sentry-core/src/api.rs. The API is also used in sentry/src/init.rs to enable session tracking by default. These usages should also be gated behind the new feature flag.

@lcian lcian added the area: core Core features of the SDK label Mar 10, 2025
@pepperoni505
Copy link

I'll take a look at this issue this week!

@lcian lcian assigned lcian and pepperoni505 and unassigned lcian Mar 10, 2025
@pepperoni505 pepperoni505 linked a pull request Mar 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Core features of the SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants